Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: Source/core/css/CSSFontFaceSource.h

Issue 719833002: Clean up virtual functions in css/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove some changes Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSFontFaceRule.h ('k') | Source/core/css/CSSFontSelector.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 27 matching lines...) Expand all
38 38
39 class CSSFontFaceSource : public NoBaseWillBeGarbageCollectedFinalized<CSSFontFa ceSource> { 39 class CSSFontFaceSource : public NoBaseWillBeGarbageCollectedFinalized<CSSFontFa ceSource> {
40 public: 40 public:
41 virtual ~CSSFontFaceSource(); 41 virtual ~CSSFontFaceSource();
42 42
43 virtual bool isLocal() const { return false; } 43 virtual bool isLocal() const { return false; }
44 virtual bool isLoading() const { return false; } 44 virtual bool isLoading() const { return false; }
45 virtual bool isLoaded() const { return true; } 45 virtual bool isLoaded() const { return true; }
46 virtual bool isValid() const { return true; } 46 virtual bool isValid() const { return true; }
47 47
48 virtual FontResource* resource() { return 0; } 48 virtual FontResource* resource() { return nullptr; }
49 void setFontFace(CSSFontFace* face) { m_face = face; } 49 void setFontFace(CSSFontFace* face) { m_face = face; }
50 50
51 PassRefPtr<SimpleFontData> getFontData(const FontDescription&); 51 PassRefPtr<SimpleFontData> getFontData(const FontDescription&);
52 52
53 virtual bool isLocalFontAvailable(const FontDescription&) { return false; } 53 virtual bool isLocalFontAvailable(const FontDescription&) { return false; }
54 virtual void beginLoadIfNeeded() { } 54 virtual void beginLoadIfNeeded() { }
55 55
56 // For UMA reporting 56 // For UMA reporting
57 virtual bool hadBlankText() { return false; } 57 virtual bool hadBlankText() { return false; }
58 58
59 virtual void trace(Visitor*); 59 virtual void trace(Visitor*);
60 60
61 protected: 61 protected:
62 CSSFontFaceSource(); 62 CSSFontFaceSource();
63 virtual PassRefPtr<SimpleFontData> createFontData(const FontDescription&) = 0; 63 virtual PassRefPtr<SimpleFontData> createFontData(const FontDescription&) = 0;
64 64
65 typedef HashMap<unsigned, RefPtr<SimpleFontData> > FontDataTable; // The has h key is composed of size synthetic styles. 65 typedef HashMap<unsigned, RefPtr<SimpleFontData> > FontDataTable; // The has h key is composed of size synthetic styles.
66 66
67 RawPtrWillBeMember<CSSFontFace> m_face; // Our owning font face. 67 RawPtrWillBeMember<CSSFontFace> m_face; // Our owning font face.
68 FontDataTable m_fontDataTable; 68 FontDataTable m_fontDataTable;
69 }; 69 };
70 70
71 } 71 }
72 72
73 #endif 73 #endif
OLDNEW
« no previous file with comments | « Source/core/css/CSSFontFaceRule.h ('k') | Source/core/css/CSSFontSelector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698