Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: Source/core/css/CSSCrossfadeValue.h

Issue 719833002: Clean up virtual functions in css/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove some changes Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSCharsetRule.h ('k') | Source/core/css/CSSFilterRule.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 21 matching lines...) Expand all
32 #include "core/fetch/ImageResourceClient.h" 32 #include "core/fetch/ImageResourceClient.h"
33 #include "core/fetch/ResourcePtr.h" 33 #include "core/fetch/ResourcePtr.h"
34 #include "platform/graphics/Image.h" 34 #include "platform/graphics/Image.h"
35 35
36 namespace blink { 36 namespace blink {
37 37
38 class ImageResource; 38 class ImageResource;
39 class CrossfadeSubimageObserverProxy; 39 class CrossfadeSubimageObserverProxy;
40 class RenderObject; 40 class RenderObject;
41 41
42 class CSSCrossfadeValue : public CSSImageGeneratorValue { 42 class CSSCrossfadeValue final : public CSSImageGeneratorValue {
43 friend class CrossfadeSubimageObserverProxy; 43 friend class CrossfadeSubimageObserverProxy;
44 public: 44 public:
45 static PassRefPtrWillBeRawPtr<CSSCrossfadeValue> create(PassRefPtrWillBeRawP tr<CSSValue> fromValue, PassRefPtrWillBeRawPtr<CSSValue> toValue) 45 static PassRefPtrWillBeRawPtr<CSSCrossfadeValue> create(PassRefPtrWillBeRawP tr<CSSValue> fromValue, PassRefPtrWillBeRawPtr<CSSValue> toValue)
46 { 46 {
47 return adoptRefWillBeNoop(new CSSCrossfadeValue(fromValue, toValue)); 47 return adoptRefWillBeNoop(new CSSCrossfadeValue(fromValue, toValue));
48 } 48 }
49 49
50 ~CSSCrossfadeValue(); 50 ~CSSCrossfadeValue();
51 51
52 String customCSSText() const; 52 String customCSSText() const;
(...skipping 24 matching lines...) Expand all
77 , m_cachedToImage(0) 77 , m_cachedToImage(0)
78 , m_crossfadeSubimageObserver(this) { } 78 , m_crossfadeSubimageObserver(this) { }
79 79
80 class CrossfadeSubimageObserverProxy final : public ImageResourceClient { 80 class CrossfadeSubimageObserverProxy final : public ImageResourceClient {
81 public: 81 public:
82 CrossfadeSubimageObserverProxy(CSSCrossfadeValue* ownerValue) 82 CrossfadeSubimageObserverProxy(CSSCrossfadeValue* ownerValue)
83 : m_ownerValue(ownerValue) 83 : m_ownerValue(ownerValue)
84 , m_ready(false) { } 84 , m_ready(false) { }
85 85
86 virtual ~CrossfadeSubimageObserverProxy() { } 86 virtual ~CrossfadeSubimageObserverProxy() { }
87 virtual void imageChanged(ImageResource*, const IntRect* = 0) override; 87 virtual void imageChanged(ImageResource*, const IntRect* = nullptr) over ride;
88 void setReady(bool ready) { m_ready = ready; } 88 void setReady(bool ready) { m_ready = ready; }
89 private: 89 private:
90 CSSCrossfadeValue* m_ownerValue; 90 CSSCrossfadeValue* m_ownerValue;
91 bool m_ready; 91 bool m_ready;
92 }; 92 };
93 93
94 void crossfadeChanged(const IntRect&); 94 void crossfadeChanged(const IntRect&);
95 95
96 RefPtrWillBeMember<CSSValue> m_fromValue; 96 RefPtrWillBeMember<CSSValue> m_fromValue;
97 RefPtrWillBeMember<CSSValue> m_toValue; 97 RefPtrWillBeMember<CSSValue> m_toValue;
98 RefPtrWillBeMember<CSSPrimitiveValue> m_percentageValue; 98 RefPtrWillBeMember<CSSPrimitiveValue> m_percentageValue;
99 99
100 ResourcePtr<ImageResource> m_cachedFromImage; 100 ResourcePtr<ImageResource> m_cachedFromImage;
101 ResourcePtr<ImageResource> m_cachedToImage; 101 ResourcePtr<ImageResource> m_cachedToImage;
102 102
103 RefPtr<Image> m_generatedImage; 103 RefPtr<Image> m_generatedImage;
104 104
105 CrossfadeSubimageObserverProxy m_crossfadeSubimageObserver; 105 CrossfadeSubimageObserverProxy m_crossfadeSubimageObserver;
106 }; 106 };
107 107
108 DEFINE_CSS_VALUE_TYPE_CASTS(CSSCrossfadeValue, isCrossfadeValue()); 108 DEFINE_CSS_VALUE_TYPE_CASTS(CSSCrossfadeValue, isCrossfadeValue());
109 109
110 } // namespace blink 110 } // namespace blink
111 111
112 #endif // CSSCrossfadeValue_h 112 #endif // CSSCrossfadeValue_h
OLDNEW
« no previous file with comments | « Source/core/css/CSSCharsetRule.h ('k') | Source/core/css/CSSFilterRule.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698