Issue 719793002: Clean up CollectLayers code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 719793002: Clean up CollectLayers code (Closed)

Created:
6 years, 1 month ago by robertphillips

Modified:
6 years, 1 month ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Clean up CollectLayers code Now that CollectLayers directly uses FillBounds we can: skip the explicit intersection with the clipBounds after an adjustAndMap call skip the storage and use of the clipBounds in SaveLayerInfo Committed: https://skia.googlesource.com/skia/+/74576eba1440c092025d6557e08da50678599d4e

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -13 lines)			Patch
	M	src/core/SkRecordDraw.cpp	View		6 chunks	+6 lines, -13 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719793002/1

6 years, 1 month ago (2014-11-12 15:16:26 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-12 15:25:05 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/74576eba1440c092025d6557e08da50678599d4e

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages