Add duration to gtest test results.

Add duration to gtest test results.

BUG=

Committed: https://crrev.com/a105b4f499357fd111b672ca8e5984e10bcbc42e
Cr-Commit-Position: refs/heads/master@{#304255}

[mikecase (-- gone --), 2014-11-13 17:27:43]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2014-11-14 01:50:24]

https://codereview.chromium.org/719753005/diff/20001/build/android/pylib/gtes...
File build/android/pylib/gtest/test_runner.py (right):

https://codereview.chromium.org/719753005/diff/20001/build/android/pylib/gtes...
build/android/pylib/gtest/test_runner.py:73: re_fail = re.compile('\[  FAILED 
\] ?(.*?)( \((.*) ms\))?\r\r\n')
Narrow the second capture a little. What do you expect preceding "ms"?
(Presumably, numbers or a decimal point.)

[mikecase (-- gone --), 2014-11-14 17:36:20]

On 2014/11/14 01:50:24, jbudorick wrote:
>
https://codereview.chromium.org/719753005/diff/20001/build/android/pylib/gtes...
> File build/android/pylib/gtest/test_runner.py (right):
> 
>
https://codereview.chromium.org/719753005/diff/20001/build/android/pylib/gtes...
> build/android/pylib/gtest/test_runner.py:73: re_fail = re.compile('\[  FAILED 
> \] ?(.*?)( \((.*) ms\))?\r\r\n')
> Narrow the second capture a little. What do you expect preceding "ms"?
> (Presumably, numbers or a decimal point.)

Well, probably should have pasted this here before having you review it but I am
parsing lines that look like ...

[       OK ] ApplicationStatusListenerTest.TwoThreads (2 ms)

(grabbed it from
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%...)

Here is my regex to try to parse it for reference...
re_ok = re.compile('\[       OK \] ?(.*?)( \((.*) ms\))?\r\r\n')

I there is no guarantee to (TIME ms) part exists because its added behind a flag
so I made it optional with the question mark. ( \((.*) ms\))?
https://cs.corp.google.com/#piper///depot/google3/third_party/gtest/src/gtest...

[mikecase (-- gone --), 2014-11-14 18:19:44]

On 2014/11/14 17:36:20, mikecase wrote:
> On 2014/11/14 01:50:24, jbudorick wrote:
> >
>
https://codereview.chromium.org/719753005/diff/20001/build/android/pylib/gtes...
> > File build/android/pylib/gtest/test_runner.py (right):
> > 
> >
>
https://codereview.chromium.org/719753005/diff/20001/build/android/pylib/gtes...
> > build/android/pylib/gtest/test_runner.py:73: re_fail = re.compile('\[ 
FAILED 
> > \] ?(.*?)( \((.*) ms\))?\r\r\n')
> > Narrow the second capture a little. What do you expect preceding "ms"?
> > (Presumably, numbers or a decimal point.)
> 
> Well, probably should have pasted this here before having you review it but I
am
> parsing lines that look like ...
> 
> [       OK ] ApplicationStatusListenerTest.TwoThreads (2 ms)
> 
> (grabbed it from
>
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%...)
> 
> Here is my regex to try to parse it for reference...
> re_ok = re.compile('\[       OK \] ?(.*?)( \((.*) ms\))?\r\r\n')
> 
> I there is no guarantee to (TIME ms) part exists because its added behind a
flag
> so I made it optional with the question mark. ( \((.*) ms\))?
>
https://cs.corp.google.com/#piper///depot/google3/third_party/gtest/src/gtest...

I decided not to do int(float(p.match.group(3))) or catch a ValueError like we
talked about because ...

p.match.group(3) is (\d+) which will never be a float since I don't allow for a
decimal point. This is fine because the time in milliseconds that
I am parsing is an int.
https://cs.corp.google.com/#piper///depot/google3/third_party/gtest/include/g...

Second, don't need to catch a ValueError since p.match.group(3) will either be a
series of digits or None. And I have an if statement to handle the None case.

[mikecase (-- gone --), 2014-11-14 18:22:37]

On 2014/11/14 18:19:44, mikecase wrote:
> On 2014/11/14 17:36:20, mikecase wrote:
> > On 2014/11/14 01:50:24, jbudorick wrote:
> > >
> >
>
https://codereview.chromium.org/719753005/diff/20001/build/android/pylib/gtes...
> > > File build/android/pylib/gtest/test_runner.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/719753005/diff/20001/build/android/pylib/gtes...
> > > build/android/pylib/gtest/test_runner.py:73: re_fail = re.compile('\[ 
> FAILED 
> > > \] ?(.*?)( \((.*) ms\))?\r\r\n')
> > > Narrow the second capture a little. What do you expect preceding "ms"?
> > > (Presumably, numbers or a decimal point.)
> > 
> > Well, probably should have pasted this here before having you review it but
I
> am
> > parsing lines that look like ...
> > 
> > [       OK ] ApplicationStatusListenerTest.TwoThreads (2 ms)
> > 
> > (grabbed it from
> >
>
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%...)
> > 
> > Here is my regex to try to parse it for reference...
> > re_ok = re.compile('\[       OK \] ?(.*?)( \((.*) ms\))?\r\r\n')
> > 
> > I there is no guarantee to (TIME ms) part exists because its added behind a
> flag
> > so I made it optional with the question mark. ( \((.*) ms\))?
> >
>
https://cs.corp.google.com/#piper///depot/google3/third_party/gtest/src/gtest...
> 
> I decided not to do int(float(p.match.group(3))) or catch a ValueError like we
> talked about because ...
> 
> p.match.group(3) is (\d+) which will never be a float since I don't allow for
a
> decimal point. This is fine because the time in milliseconds that
> I am parsing is an int.
>
https://cs.corp.google.com/#piper///depot/google3/third_party/gtest/include/g...
> 
> Second, don't need to catch a ValueError since p.match.group(3) will either be
a
> series of digits or None. And I have an if statement to handle the None case.

Locally tested it, heres an example print statement.

[       OK ] DatabasesTableTest.TestIt (3 ms)

p.match.group(1): DatabasesTableTest.TestIt
p.match.group(2):  (3 ms)
p.match.group(3): 3

[jbudorick, 2014-11-14 18:36:42]

lgtm

[mikecase (-- gone --), 2014-11-14 18:58:35]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2014-11-14 18:59:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/719753005/40001

[commit-bot: I haz the power, 2014-11-14 19:56:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-14 19:56:54]

Patchset 3 (id:??) landed as
https://crrev.com/a105b4f499357fd111b672ca8e5984e10bcbc42e
Cr-Commit-Position: refs/heads/master@{#304255}