Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 719723002: applyAllProperty should not apply non-inherited properties when inheritedOnly (Closed)

Created:
6 years, 1 month ago by tasak
Modified:
6 years, 1 month ago
Reviewers:
Timothy Loh, dglazkov
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

applyAllProperty should not apply non-inherited properties when inheritedOnly BUG=432257 TEST=fast/dom/shadow/all-in-shadow-tree.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185266

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
A LayoutTests/fast/dom/shadow/all-in-shadow-tree.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/all-in-shadow-tree-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tasak
Would you review this CL? https://codereview.chromium.org/719723002/diff/1/LayoutTests/fast/dom/shadow/all-in-shadow-tree.html File LayoutTests/fast/dom/shadow/all-in-shadow-tree.html (right): https://codereview.chromium.org/719723002/diff/1/LayoutTests/fast/dom/shadow/all-in-shadow-tree.html#newcode21 LayoutTests/fast/dom/shadow/all-in-shadow-tree.html:21: shouldBe('window.getComputedStyle(targets[1]).width', '"100px"'); targets[1]' styleForElement ...
6 years, 1 month ago (2014-11-13 01:16:28 UTC) #2
Timothy Loh
lgtm https://codereview.chromium.org/719723002/diff/1/LayoutTests/fast/dom/shadow/all-in-shadow-tree.html File LayoutTests/fast/dom/shadow/all-in-shadow-tree.html (right): https://codereview.chromium.org/719723002/diff/1/LayoutTests/fast/dom/shadow/all-in-shadow-tree.html#newcode12 LayoutTests/fast/dom/shadow/all-in-shadow-tree.html:12: sr.innerHTML = '<div style="all: initial; display: block; width:100%; ...
6 years, 1 month ago (2014-11-13 01:30:25 UTC) #4
tasak
Thank you for review. https://codereview.chromium.org/719723002/diff/1/LayoutTests/fast/dom/shadow/all-in-shadow-tree.html File LayoutTests/fast/dom/shadow/all-in-shadow-tree.html (right): https://codereview.chromium.org/719723002/diff/1/LayoutTests/fast/dom/shadow/all-in-shadow-tree.html#newcode12 LayoutTests/fast/dom/shadow/all-in-shadow-tree.html:12: sr.innerHTML = '<div style="all: initial; ...
6 years, 1 month ago (2014-11-13 02:48:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719723002/20001
6 years, 1 month ago (2014-11-13 02:49:06 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 04:32:36 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185266

Powered by Google App Engine
This is Rietveld 408576698