Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 719713002: [arm] Remove code duplication in instruction selector. Refactoring. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[arm] Remove code duplication in instruction selector. Refactoring. TEST=unittests R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25292

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -137 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 8 chunks +75 lines, -137 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-11-12 12:05:30 UTC) #2
dcarney
lgtm
6 years, 1 month ago (2014-11-12 12:07:22 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-11-12 12:07:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25292 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698