Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 719643002: Add jrummell & sandersd to various media OWNERS files. (Closed)

Created:
6 years, 1 month ago by ddorwin
Modified:
6 years, 1 month ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add jrummell & sandersd to various media OWNERS files. Also, remove wjia. Committed: https://crrev.com/22efab19c8cf7986c27e22098f5453453f9e883f Cr-Commit-Position: refs/heads/master@{#303954}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove wjia. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M chrome/renderer/media/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/resources/media/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/media/OWNERS View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/media/OWNERS View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/media/OWNERS View 1 1 chunk +3 lines, -2 lines 0 comments Download
M media/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
ddorwin
6 years, 1 month ago (2014-11-12 01:50:28 UTC) #2
DaleCurtis
Removal in this one up to you. https://codereview.chromium.org/719643002/diff/1/content/common/media/OWNERS File content/common/media/OWNERS (right): https://codereview.chromium.org/719643002/diff/1/content/common/media/OWNERS#newcode8 content/common/media/OWNERS:8: wjia@chromium.org Ditto. ...
6 years, 1 month ago (2014-11-12 02:03:42 UTC) #4
DaleCurtis
also lgtm, congratulations! \o/
6 years, 1 month ago (2014-11-12 02:04:10 UTC) #5
jrummell
lgtm
6 years, 1 month ago (2014-11-12 18:00:33 UTC) #7
ddorwin
https://codereview.chromium.org/719643002/diff/1/content/test/data/media/OWNERS File content/test/data/media/OWNERS (right): https://codereview.chromium.org/719643002/diff/1/content/test/data/media/OWNERS#newcode9 content/test/data/media/OWNERS:9: wjia@chromium.org On 2014/11/12 02:03:42, DaleCurtis wrote: > Gone from ...
6 years, 1 month ago (2014-11-12 18:02:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719643002/20001
6 years, 1 month ago (2014-11-13 00:26:52 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-13 01:30:02 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 01:30:48 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/22efab19c8cf7986c27e22098f5453453f9e883f
Cr-Commit-Position: refs/heads/master@{#303954}

Powered by Google App Engine
This is Rietveld 408576698