Only use posix_memalign on Solaris if it's available

Only use posix_memalign on Solaris if it's available

R=svenpanne@chromium.org
LOG=n
BUG=v8:3357

[Sven Panne, 2014-11-12 12:33:55]

https://codereview.chromium.org/719523003/diff/1/src/allocation.cc
File src/allocation.cc (right):

https://codereview.chromium.org/719523003/diff/1/src/allocation.cc#newcode92
src/allocation.cc:92: #elif V8_LIBC_BIONIC || (V8_OS_SOLARIS &&
!defined(HAS_POSIX_MEMALIGN))
Hmmm, where does HAS_POSIX_MEMALIGN come from? Furthermore, GNU convention would
be HAVE_POSIX_MEMALIGN...

[jochen (gone - plz use gerrit), 2014-11-12 14:47:30]

On 2014/11/12 at 12:33:55, svenpanne wrote:
> https://codereview.chromium.org/719523003/diff/1/src/allocation.cc
> File src/allocation.cc (right):
> 
> https://codereview.chromium.org/719523003/diff/1/src/allocation.cc#newcode92
> src/allocation.cc:92: #elif V8_LIBC_BIONIC || (V8_OS_SOLARIS &&
!defined(HAS_POSIX_MEMALIGN))
> Hmmm, where does HAS_POSIX_MEMALIGN come from? Furthermore, GNU convention
would be HAVE_POSIX_MEMALIGN...

*shrug*, no idea

we can try || V8_IS_SOLARIS? it's not like I had a solaris 10 to test...

I think the successor version has posix_memalign(), but then again, if we can
deal with memalign anways...

[Sven Panne, 2014-11-12 15:51:49]

https://codereview.chromium.org/719523003/diff/20001/src/allocation.cc
File src/allocation.cc (right):

https://codereview.chromium.org/719523003/diff/20001/src/allocation.cc#newcode92
src/allocation.cc:92: #elif V8_LIBC_BIONIC || V8_OS_SOLARIS
Hmmm, this still doesn't look right, some Solaris versions have this, some
don't. Furthermore, the #ifdefs are out of sync with AlignedFree below.

The right way to fix this would be adding #defines for HAVE__ALIGNED_MALLOC,
HAVE_MEMALIGN, and HAVE_POSIX_MEMALIGN to v8config.h, including the selection
logic. Autotools anyone...? :-D

[jochen (gone - plz use gerrit), 2014-12-03 09:00:39]

i'll drop this... somebody with access to solaris should do this