tools/metrics/actions/extract_actions.py - Issue 719463003: Presubmit checks for user actions intorduced in HTML files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/actions/extract_actions.py

Issue 719463003: Presubmit checks for user actions intorduced in HTML files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unit tests added Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/metrics/actions/extract_actions.py

diff --git a/tools/metrics/actions/extract_actions.py b/tools/metrics/actions/extract_actions.py

index 63818f331165614dd04354261943a16ccd6b93bd..ecd72a3b3baf84e17174b4bdc9c1d56800485427 100755

--- a/tools/metrics/actions/extract_actions.py

+++ b/tools/metrics/actions/extract_actions.py

@@ -506,7 +506,7 @@ def WalkDirectory(root_path, actions, extensions, callback):

dirs.remove('.git')

for file in files:

ext = os.path.splitext(file)[1]

- if ext in extensions:

+ if ext and ext in extensions:

Alexei Svitkine (slow) 2014/11/12 22:27:00 This seems unrelated to the change you're making t

gayane -on leave until 09-2017 2014/11/15 00:09:09 Done.

callback(os.path.join(path, file), actions)

def AddLiteralActions(actions):

« chrome/browser/resources/PRESUBMIT_test.py ('K') | « chrome/browser/resources/PRESUBMIT_test.py ('k') | no next file » | no next file with comments »