PRESUBMIT.py - Issue 719463003: Presubmit checks for user actions intorduced in HTML files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 719463003: Presubmit checks for user actions intorduced in HTML files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 7c8d58e35a1bf00d995f381d618696bf2be1b534..f0eecfa7ddc51d042e6173e4ad3f6c43c3334134 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -8,7 +8,6 @@ See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

for more details about the presubmit API built into gcl.

"""

Alexei Svitkine (slow) 2014/11/11 20:36:41 Nit: Revert changes to this file.

gayane -on leave until 09-2017 2014/11/12 22:00:23 Done.

_EXCLUDED_PATHS = (

r"^breakpad[\\\/].*",

r"^native_client_sdk[\\\/]src[\\\/]build_tools[\\\/]make_rules.py",

@@ -1073,7 +1072,7 @@ def _CheckUserActionUpdate(input_api, output_api):

# for actions.xml will do a more complete presubmit check.

return []

- file_filter = lambda f: f.LocalPath().endswith(('.cc', '.mm'))

+ file_filter = lambda f: f.LocalPath().endswith(('.cc', '.mm', '.c', '.m'))

action_re = r'[^a-zA-Z]UserMetricsAction\("([^"]*)'

current_actions = None

for f in input_api.AffectedFiles(file_filter=file_filter):

« no previous file with comments | « no previous file | chrome/browser/resources/PRESUBMIT.py » ('j') | chrome/browser/resources/PRESUBMIT.py » ('J')