cc/blink/web_scroll_offset_animation_curve_impl.cc - Issue 719453007: Make Keyframe use TimeTicks/TimeDelta to represent time instead of double.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/blink/web_scroll_offset_animation_curve_impl.cc

Issue 719453007: Make Keyframe use TimeTicks/TimeDelta to represent time instead of double. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/animation/scroll_offset_animation_curve_unittest.cc ('K') | « cc/blink/web_float_animation_curve_impl.cc ('k') | cc/blink/web_transform_animation_curve_impl.cc » ('j') | cc/input/top_controls_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/blink/web_scroll_offset_animation_curve_impl.cc

diff --git a/cc/blink/web_scroll_offset_animation_curve_impl.cc b/cc/blink/web_scroll_offset_animation_curve_impl.cc

index ba55d5b33bd4526c3033e2b168debd490e972d38..43b85461589ff65054b885eecc3a7e00a44928b0 100644

--- a/cc/blink/web_scroll_offset_animation_curve_impl.cc

+++ b/cc/blink/web_scroll_offset_animation_curve_impl.cc

@@ -34,7 +34,8 @@ void WebScrollOffsetAnimationCurveImpl::setInitialValue(

}

WebFloatPoint WebScrollOffsetAnimationCurveImpl::getValue(double time) const {

- gfx::ScrollOffset value = curve_->GetValue(time);

+ gfx::ScrollOffset value =

+ curve_->GetValue(base::TimeDelta::FromSeconds(time));

ajuma 2014/11/14 15:12:33 This should be FromSecondsD. (this is likely what'

patro 2014/11/17 13:26:47 Done.

return WebFloatPoint(value.x(), value.y());

}