Make Keyframe use TimeTicks/TimeDelta to represent time instead of double.

cc/input/top_controls_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/input/top_controls_manager.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "cc/animation/keyframed_animation_curve.h"
@@ skipping 149 matching lines @@
 
   client_->SetControlsTopOffset(controls_top_offset);
 
   client_->DidChangeTopControlsPosition();
 }
 
 gfx::Vector2dF TopControlsManager::Animate(base::TimeTicks monotonic_time) {
   if (!top_controls_animation_ || !client_->HaveRootScrollLayer())
     return gfx::Vector2dF();
 
-  double time = (monotonic_time - base::TimeTicks()).InMillisecondsF();
+  base::TimeDelta time = monotonic_time - base::TimeTicks();

[ajuma, 2014/11/14 15:12:33]

The existing code treats time as a value in milliseconds (rather than in
seconds), so this change will have the effect of slowing down the animation by a
factor of 1000 (I think). Do any tests fail (in
top_controls_manager_unittest.cc) because of this? If not, we should add test
coverage (and make sure that the behavior stays the same before and after this
change).

[patro, 2014/11/17 13:26:47]

No tests are not failing in top_controls_manager_unittest.cc
This is beacuse existing code treats it as milliseconds. 
So we are creating keyframe in milliseconds and getValue is also called in
milliseconds.

Now in this change we are creating in TimeDelta and getValue is also in
TimeDelta.

 
   float old_offset = client_->ControlsTopOffset();
   SetControlsTopOffset(top_controls_animation_->GetValue(time));
 
   if (IsAnimationCompleteAtTime(monotonic_time))
     ResetAnimations();
 
   gfx::Vector2dF scroll_delta(0.f, client_->ControlsTopOffset() - old_offset);
   return scroll_delta;
 }
@@ skipping 11 matching lines @@
 
   if (direction == HIDING_CONTROLS &&
       client_->ControlsTopOffset() == -top_controls_height_) {
     return;
   }
 
   if (top_controls_animation_ && animation_direction_ == direction)
     return;
 
   top_controls_animation_ = KeyframedFloatAnimationCurve::Create();
-  double start_time =
-      (gfx::FrameTime::Now() - base::TimeTicks()).InMillisecondsF();
+  base::TimeDelta start_time = gfx::FrameTime::Now() - base::TimeTicks();

[ajuma, 2014/11/14 15:12:33]

Same comment as above.

[patro, 2014/11/17 13:26:47]

Done.

   top_controls_animation_->AddKeyframe(
       FloatKeyframe::Create(start_time, client_->ControlsTopOffset(), nullptr));
   float max_ending_offset =
       (direction == SHOWING_CONTROLS ? 1 : -1) * top_controls_height_;
-  top_controls_animation_->AddKeyframe(
-      FloatKeyframe::Create(start_time + kShowHideMaxDurationMs,
-                            client_->ControlsTopOffset() + max_ending_offset,
-                            EaseTimingFunction::Create()));
+  top_controls_animation_->AddKeyframe(FloatKeyframe::Create(
+      start_time + base::TimeDelta::FromMilliseconds(kShowHideMaxDurationMs),
+      client_->ControlsTopOffset() + max_ending_offset,
+      EaseTimingFunction::Create()));
   animation_direction_ = direction;
   client_->DidChangeTopControlsPosition();
 }
 
 void TopControlsManager::StartAnimationIfNecessary() {
   if (client_->ControlsTopOffset() != 0
       && client_->ControlsTopOffset() != -top_controls_height_) {
     AnimationDirection show_controls = NO_ANIMATION;
 
     if (client_->ControlsTopOffset() >= -top_controls_show_height_) {
@@ skipping 12 matching lines @@
 
     if (show_controls != NO_ANIMATION)
       SetupAnimation(show_controls);
   }
 }
 
 bool TopControlsManager::IsAnimationCompleteAtTime(base::TimeTicks time) {
   if (!top_controls_animation_)
     return true;
 
-  double time_ms = (time - base::TimeTicks()).InMillisecondsF();
+  base::TimeDelta time_ms = time - base::TimeTicks();

[ajuma, 2014/11/14 15:12:33]

Here too.

[patro, 2014/11/17 13:26:47]

Done.

   float new_offset = top_controls_animation_->GetValue(time_ms);
 
   if ((animation_direction_ == SHOWING_CONTROLS && new_offset >= 0) ||
       (animation_direction_ == HIDING_CONTROLS
           && new_offset <= -top_controls_height_)) {
     return true;
   }
   return false;
 }
 
 }  // namespace cc