Make Keyframe use TimeTicks/TimeDelta to represent time instead of double.

cc/animation/scroll_offset_animation_curve_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/animation/scroll_offset_animation_curve.h"
 
 #include "cc/animation/timing_function.h"
 #include "cc/test/geometry_test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 52 matching lines @@
           EaseInOutTimingFunction::Create().Pass()));
   curve->SetInitialValue(initial_value);
 
   double duration_in_seconds = curve->Duration().InSecondsF();
   EXPECT_GT(curve->Duration().InSecondsF(), 0);
   EXPECT_LT(curve->Duration().InSecondsF(), 0.1);
 
   EXPECT_EQ(AnimationCurve::ScrollOffset, curve->Type());
   EXPECT_EQ(duration_in_seconds, curve->Duration().InSecondsF());
 
-  EXPECT_VECTOR2DF_EQ(initial_value, curve->GetValue(-1.0));
-  EXPECT_VECTOR2DF_EQ(initial_value, curve->GetValue(0.0));
+  EXPECT_VECTOR2DF_EQ(initial_value,
+                      curve->GetValue(base::TimeDelta::FromSecondsD(-1.0)));
+  EXPECT_VECTOR2DF_EQ(initial_value, curve->GetValue(base::TimeDelta()));
   EXPECT_VECTOR2DF_EQ(gfx::ScrollOffset(6.f, 30.f),
-                      curve->GetValue(duration_in_seconds / 2.0));
-  EXPECT_VECTOR2DF_EQ(target_value, curve->GetValue(duration_in_seconds));
-  EXPECT_VECTOR2DF_EQ(target_value, curve->GetValue(duration_in_seconds + 1.0));
+                      curve->GetValue(base::TimeDelta::FromSecondsD(
+                          duration_in_seconds / 2.0)));
+  EXPECT_VECTOR2DF_EQ(
+      target_value,
+      curve->GetValue(base::TimeDelta::FromSecondsD(duration_in_seconds)));
+  EXPECT_VECTOR2DF_EQ(target_value,
+                      curve->GetValue(base::TimeDelta::FromSecondsD(
+                          duration_in_seconds + 1.0)));
 
   // Verify that GetValue takes the timing function into account.
-  gfx::ScrollOffset value = curve->GetValue(duration_in_seconds / 4.0);
+  gfx::ScrollOffset value =
+      curve->GetValue(base::TimeDelta::FromSecondsD(duration_in_seconds / 4.0));
   EXPECT_NEAR(3.0333f, value.x(), 0.00015f);
   EXPECT_NEAR(37.4168f, value.y(), 0.00015f);
 }
 
 // Verify that a clone behaves exactly like the original.
 TEST(ScrollOffsetAnimationCurveTest, Clone) {
   gfx::ScrollOffset initial_value(2.f, 40.f);
   gfx::ScrollOffset target_value(10.f, 20.f);
   scoped_ptr<ScrollOffsetAnimationCurve> curve(
       ScrollOffsetAnimationCurve::Create(
           target_value,
           EaseInOutTimingFunction::Create().Pass()));
   curve->SetInitialValue(initial_value);
   double duration_in_seconds = curve->Duration().InSecondsF();

[ajuma, 2014/11/14 15:12:33]

We should just use duration as a TimeDelta rather than converting to a double
here (and then use TimeUtil to scale as needed below).

[patro, 2014/11/17 13:26:47]

Done.

 
   scoped_ptr<AnimationCurve> clone(curve->Clone().Pass());
 
   EXPECT_EQ(AnimationCurve::ScrollOffset, clone->Type());
   EXPECT_EQ(duration_in_seconds, clone->Duration().InSecondsF());
 
   EXPECT_VECTOR2DF_EQ(initial_value,
-                      clone->ToScrollOffsetAnimationCurve()->GetValue(-1.0));
-  EXPECT_VECTOR2DF_EQ(initial_value,
-                      clone->ToScrollOffsetAnimationCurve()->GetValue(0.0));
-  EXPECT_VECTOR2DF_EQ(gfx::ScrollOffset(6.f, 30.f),
                       clone->ToScrollOffsetAnimationCurve()->GetValue(
-                          duration_in_seconds / 2.0));
+                          base::TimeDelta::FromSecondsD(-1.0)));
+  EXPECT_VECTOR2DF_EQ(
+      initial_value,
+      clone->ToScrollOffsetAnimationCurve()->GetValue(base::TimeDelta()));
+  EXPECT_VECTOR2DF_EQ(
+      gfx::ScrollOffset(6.f, 30.f),
+      clone->ToScrollOffsetAnimationCurve()->GetValue(
+          base::TimeDelta::FromSecondsD(duration_in_seconds / 2.0)));
+  EXPECT_VECTOR2DF_EQ(target_value,
+                      clone->ToScrollOffsetAnimationCurve()->GetValue(
+                          base::TimeDelta::FromSecondsD(duration_in_seconds)));
   EXPECT_VECTOR2DF_EQ(
       target_value,
-      clone->ToScrollOffsetAnimationCurve()->GetValue(duration_in_seconds));
-  EXPECT_VECTOR2DF_EQ(target_value,
-                      clone->ToScrollOffsetAnimationCurve()->GetValue(
-                          duration_in_seconds + 1.0));
+      clone->ToScrollOffsetAnimationCurve()->GetValue(
+          base::TimeDelta::FromSecondsD(duration_in_seconds + 1.0)));
 
   // Verify that the timing function was cloned correctly.
   gfx::ScrollOffset value = clone->ToScrollOffsetAnimationCurve()->GetValue(
-      duration_in_seconds / 4.0);
+      base::TimeDelta::FromSecondsD(duration_in_seconds / 4.0));
   EXPECT_NEAR(3.0333f, value.x(), 0.00015f);
   EXPECT_NEAR(37.4168f, value.y(), 0.00015f);
 }
 
 TEST(ScrollOffsetAnimationCurveTest, UpdateTarget) {
   gfx::ScrollOffset initial_value(0.f, 0.f);
   gfx::ScrollOffset target_value(0.f, 3600.f);
   scoped_ptr<ScrollOffsetAnimationCurve> curve(
       ScrollOffsetAnimationCurve::Create(
           target_value, EaseInOutTimingFunction::Create().Pass()));
   curve->SetInitialValue(initial_value);
   EXPECT_EQ(1.0, curve->Duration().InSecondsF());
-  EXPECT_EQ(1800.0, curve->GetValue(0.5).y());
-  EXPECT_EQ(3600.0, curve->GetValue(1.0).y());
+  EXPECT_EQ(1800.0, curve->GetValue(base::TimeDelta::FromSecondsD(0.5)).y());
+  EXPECT_EQ(3600.0, curve->GetValue(base::TimeDelta::FromSecondsD(1.0)).y());
 
   curve->UpdateTarget(0.5, gfx::ScrollOffset(0.0, 9900.0));
 
   EXPECT_EQ(2.0, curve->Duration().InSecondsF());
-  EXPECT_EQ(1800.0, curve->GetValue(0.5).y());
-  EXPECT_NEAR(5566.49, curve->GetValue(1.0).y(), 0.01);
-  EXPECT_EQ(9900.0, curve->GetValue(2.0).y());
+  EXPECT_EQ(1800.0, curve->GetValue(base::TimeDelta::FromSecondsD(0.5)).y());
+  EXPECT_NEAR(5566.49, curve->GetValue(base::TimeDelta::FromSecondsD(1.0)).y(),
+              0.01);
+  EXPECT_EQ(9900.0, curve->GetValue(base::TimeDelta::FromSecondsD(2.0)).y());
 
   curve->UpdateTarget(1.0, gfx::ScrollOffset(0.0, 7200.0));
 
   EXPECT_NEAR(1.674, curve->Duration().InSecondsF(), 0.01);
-  EXPECT_NEAR(5566.49, curve->GetValue(1.0).y(), 0.01);
-  EXPECT_EQ(7200.0, curve->GetValue(1.674).y());
+  EXPECT_NEAR(5566.49, curve->GetValue(base::TimeDelta::FromSecondsD(1.0)).y(),
+              0.01);
+  EXPECT_EQ(7200.0, curve->GetValue(base::TimeDelta::FromSecondsD(1.674)).y());
 }
 
 }  // namespace
 }  // namespace cc