Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: dart/pkg/compiler/lib/src/universe/universe.dart

Issue 719443002: Incremental compilation: set up inheritance. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Negate and document ClassWorld.hasClosedWorldAssumption. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/pkg/compiler/lib/src/universe/universe.dart
diff --git a/dart/pkg/compiler/lib/src/universe/universe.dart b/dart/pkg/compiler/lib/src/universe/universe.dart
index e5e3915d8518b57786f3721788cf218bfb612466..5b60d70850bb7794a34e229552e257cecbfe88b0 100644
--- a/dart/pkg/compiler/lib/src/universe/universe.dart
+++ b/dart/pkg/compiler/lib/src/universe/universe.dart
@@ -747,6 +747,13 @@ class TypedSelector extends Selector {
new Map<Selector, Map<TypeMask, TypedSelector>>();
factory TypedSelector(TypeMask mask, Selector selector, World world) {
+ if (!world.hasClosedWorldAssumption) {
Johnni Winther 2014/11/17 09:56:32 Add a TODO (for me) to improve the use of TypedSel
+ bool isNullable = mask.isNullable;
+ mask = world.compiler.typesTask.dynamicType;
+ if (isNullable) {
+ mask = mask.nullable();
+ }
+ }
// TODO(johnniwinther): Allow more TypeSelector kinds during resoluton.
assert(world.isClosed || mask.isExact);
if (selector.mask == mask) return selector;
« no previous file with comments | « dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart ('k') | dart/pkg/compiler/lib/src/warnings.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698