Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: dart/pkg/dart2js_incremental/lib/library_updater.dart

Issue 719443002: Incremental compilation: set up inheritance. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« dart/pkg/compiler/lib/src/ssa/codegen.dart ('K') | « dart/pkg/compiler/lib/src/ssa/codegen.dart ('k') | dart/tests/try/web/incremental_compilation_update_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/pkg/dart2js_incremental/lib/library_updater.dart
diff --git a/dart/pkg/dart2js_incremental/lib/library_updater.dart b/dart/pkg/dart2js_incremental/lib/library_updater.dart
index c206760c08d2304859f34229bc464a199048ed80..df7a85a6dd04a75da8259e242ff5e442e044f3da 100644
--- a/dart/pkg/dart2js_incremental/lib/library_updater.dart
+++ b/dart/pkg/dart2js_incremental/lib/library_updater.dart
@@ -417,7 +417,14 @@ class LibraryUpdater extends JsFeatures {
}
for (ClassElementX cls in newClasses) {
- // TODO(ahe): Set up superclasses.
+ if (cls.isObject) continue;
+ jsAst.Node classAccess = namer.elementAccess(cls);
+ jsAst.Node superAccess = namer.elementAccess(cls.superclass);
+
+ updates.add(
+ js.statement(
+ r'self.$dart_unsafe_eval.inheritFrom(#, #)',
+ [classAccess, superAccess]));
}
for (Element element in compiler.enqueuer.codegen.newlyEnqueuedElements) {
« dart/pkg/compiler/lib/src/ssa/codegen.dart ('K') | « dart/pkg/compiler/lib/src/ssa/codegen.dart ('k') | dart/tests/try/web/incremental_compilation_update_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698