Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 719413002: Added new AutoplayEnabledThroughLoad entry to the Blink.MediaElement.Autoplay histogram (Closed)

Created:
6 years, 1 month ago by oystein (OOO til 10th of July)
Modified:
6 years, 1 month ago
Reviewers:
qinmin, adamk
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Added new entry to the Blink.MediaElement.Autoplay histogram to account for cases where autoplay is reenabled on a Media element by a user-gesture triggered script R=qinmin,adamk BUG=432734 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185332

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
DaleCurtis
-myself since qinmin@ seems to have a better grasp of this state machine than I ...
6 years, 1 month ago (2014-11-13 02:25:35 UTC) #4
qinmin
lgtm, please also update the histograms.xml for this
6 years, 1 month ago (2014-11-13 03:14:54 UTC) #6
adamk
lgtm stamp for OWNERS
6 years, 1 month ago (2014-11-13 21:10:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719413002/20001
6 years, 1 month ago (2014-11-13 22:14:30 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 00:17:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as 185332

Powered by Google App Engine
This is Rietveld 408576698