Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 719403005: One instead of two runtime calls when initializing regexp. (Closed)

Created:
6 years, 1 month ago by Yang
Modified:
6 years, 1 month ago
Reviewers:
ulan, aandrey
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

One instead of two runtime calls when initializing regexp. R=ulan@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/bc597301b0504b912a2714b7b3f94d425ae70984

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -126 lines) Patch
M src/compiler/linkage.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/jsregexp.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/jsregexp.cc View 2 chunks +1 line, -24 lines 0 comments Download
M src/regexp.js View 1 chunk +1 line, -40 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 3 chunks +83 lines, -55 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
6 years, 1 month ago (2014-11-19 12:32:05 UTC) #1
aandrey
FYI https://codereview.chromium.org/719403005/diff/1/src/runtime/runtime-regexp.cc File src/runtime/runtime-regexp.cc (right): https://codereview.chromium.org/719403005/diff/1/src/runtime/runtime-regexp.cc#newcode803 src/runtime/runtime-regexp.cc:803: JSRegExp::Flags RegExpFlagsFromString(Handle<String> flags, bool* success) { static? https://codereview.chromium.org/719403005/diff/1/src/runtime/runtime-regexp.cc#newcode808 ...
6 years, 1 month ago (2014-11-19 13:16:54 UTC) #3
ulan
LGTM if Andrey's comments are addressed.
6 years, 1 month ago (2014-11-19 13:30:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719403005/20001
6 years, 1 month ago (2014-11-19 13:46:41 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 14:13:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698