Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 719383002: Cleanup: supervised_user_theme.cc should not be built if themes are not enabled. (Closed)

Created:
6 years, 1 month ago by Lei Zhang
Modified:
6 years, 1 month ago
Reviewers:
Marc Treib
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: supervised_user_theme.cc should not be built if themes are not enabled. BUG=159847 Committed: https://crrev.com/169a636e64f462fab46da18c97b2b6dc2fb06225 Cr-Commit-Position: refs/heads/master@{#304073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
6 years, 1 month ago (2014-11-13 00:00:17 UTC) #2
Marc Treib
On 2014/11/13 00:00:17, Lei Zhang wrote: lgtm
6 years, 1 month ago (2014-11-13 14:05:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719383002/1
6 years, 1 month ago (2014-11-13 20:00:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 20:48:08 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 20:48:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/169a636e64f462fab46da18c97b2b6dc2fb06225
Cr-Commit-Position: refs/heads/master@{#304073}

Powered by Google App Engine
This is Rietveld 408576698