Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Issue 719343002: Remove implicit conversions from scoped_refptr to T* in content/ (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
nasko
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, piman+watch_chromium.org, plundblad+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in content/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 Committed: https://crrev.com/b933848d698a7b3b4d2022ac1e4cd07acdf0b948 Cr-Commit-Position: refs/heads/master@{#303943}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -27 lines) Patch
M content/browser/accessibility/accessibility_win_browsertest.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M content/child/child_shared_bitmap_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 12 chunks +16 lines, -16 lines 4 comments Download

Messages

Total messages: 9 (2 generated)
dcheng
6 years, 1 month ago (2014-11-12 23:09:44 UTC) #2
nasko
LGTM with a couple of nits. https://codereview.chromium.org/719343002/diff/1/content/common/gpu/media/dxva_video_decode_accelerator.cc File content/common/gpu/media/dxva_video_decode_accelerator.cc (right): https://codereview.chromium.org/719343002/diff/1/content/common/gpu/media/dxva_video_decode_accelerator.cc#newcode332 content/common/gpu/media/dxva_video_decode_accelerator.cc:332: hr = decoder.device_->StretchRect(dest_surface, ...
6 years, 1 month ago (2014-11-12 23:18:25 UTC) #3
dcheng
How strongly do you feel about the formatting nits? =P I think it's unlikely the ...
6 years, 1 month ago (2014-11-12 23:22:49 UTC) #4
nasko
On 2014/11/12 23:22:49, dcheng wrote: > How strongly do you feel about the formatting nits? ...
6 years, 1 month ago (2014-11-13 00:02:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719343002/1
6 years, 1 month ago (2014-11-13 00:06:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 00:51:15 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 00:52:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b933848d698a7b3b4d2022ac1e4cd07acdf0b948
Cr-Commit-Position: refs/heads/master@{#303943}

Powered by Google App Engine
This is Rietveld 408576698