Move UI specific implementation from ProfileSyncService to SyncSetupFlowHandler.

chrome/browser/sync/sync_setup_wizard.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/sync_setup_wizard.h"
 
 #include <stddef.h>
 #include <ostream>
 
 #include "base/logging.h"
@@ skipping 65 matching lines @@
 bool SyncSetupWizard::IsVisible() const {
   return flow_container_->get_flow() != NULL;
 }
 
 void SyncSetupWizard::Focus() {
   SyncSetupFlow* flow = flow_container_->get_flow();
   if (flow)
     flow->Focus();
 }
 
+void SyncSetupWizard::ShowSyncSetup() {
+  SyncSetupFlow* flow = flow_container_->get_flow();
+  if (flow)
+    flow->ShowSyncSetup();

[tim (not reviewing), 2011/07/07 17:49:47]

this just looks like a sub-case of Step as implemented already... what am I
missing?

[qsr (NOT THE RIGHT qsr), 2011/07/08 08:51:43]

 This is calling ShowSyncSetup method on flow, that will ultimately call:
 
BrowserList::GetLastActiveWithProfile(profile)->ShowOptionsTab(chrome::kSyncSetupSubPage);

 Step itself is never doing it, and the SyncService can call either of the 2
methods depending on the context.

 I'm not sure to understand what you propose. The aim of this patch is to move
all UI related code to the implementation of the flow handler.

+}
+
 SyncSetupFlow* SyncSetupWizard::AttachSyncSetupHandler(
     SyncSetupFlowHandler* handler) {
   SyncSetupFlow* flow = flow_container_->get_flow();
   if (!flow || !flow->AttachSyncSetupHandler(handler))
     return NULL;
 
   return flow;
 }