Move UI specific implementation from ProfileSyncService to SyncSetupFlowHandler.

chrome/browser/sync/profile_sync_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/profile_sync_service.h"
 
 #include <stddef.h>
 #include <map>
 #include <ostream>
 #include <set>
@@ skipping 837 matching lines @@
 
 void ProfileSyncService::PromptForExistingPassphrase() {
   if (WizardIsVisible()) {
     wizard_.Focus();
     return;
   }
 
   ShowSyncSetup(SyncSetupWizard::ENTER_PASSPHRASE);
 }
 
 void ProfileSyncService::ShowSyncSetup(SyncSetupWizard::State state) {

[Andrew T Wilson (Slow), 2011/07/07 17:44:23]

So, I'm wondering if we should just completely get rid of this routine, and
instead add a ShowSyncSetup(SyncSetupWizard::State state) routine to
SyncSetupWizard that does exactly what this does (steps to that state, and
displays the setup appropriately). And all calls to this routine
(ShowSyncSetup(<state>)) would instead change to wizard_.ShowSyncSetup(<state>).

[tim (not reviewing), 2011/07/07 17:49:47]

hm. wizard_.Step is supposed to do exactly that; advance, and show
appropriately... that's what the if (flow) and SyncSetupFlow::Run stuff is about
in there.

   wizard_.Step(state);
-  BrowserList::GetLastActiveWithProfile(profile())->ShowOptionsTab(
-      chrome::kSyncSetupSubPage);
+  wizard_.ShowSyncSetup();
 }
 
 SyncBackendHost::StatusSummary ProfileSyncService::QuerySyncStatusSummary() {
   if (backend_.get() && backend_initialized_)
     return backend_->GetStatusSummary();
   else
     return SyncBackendHost::Status::OFFLINE_UNUSABLE;
 }
 
 SyncBackendHost::Status ProfileSyncService::QueryDetailedSyncStatus() {
@@ skipping 564 matching lines @@
   // is initialized, all enabled data types are consistent with one
   // another, and no unrecoverable error has transpired.
   if (unrecoverable_error_detected_)
     return false;
 
   if (!data_type_manager_.get())
     return false;
 
   return data_type_manager_->state() == DataTypeManager::CONFIGURED;
 }