Add type annotations to gallery/js/ribbon.js.

Add type annotations to gallery/js/ribbon.js.

BUG=406995
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default | grep "ribbon.js" -2

Committed: https://crrev.com/90c518c26ed4ed5c2c2d84168d0526aa0b2373e3
Cr-Commit-Position: refs/heads/master@{#304158}

[yawano, 2014-11-13 06:47:29]

yawano@chromium.org changed reviewers:
+ fukino@chromium.org

[yawano, 2014-11-13 06:47:29]

PTAL. Thanks!

[fukino, 2014-11-13 07:14:26]

thanks!

https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/ribbon.js (right):

https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/ribbon.js:41: /** @type {!Object} */
self.renderCache_ = {};
I like the following style to be consistent with other classes.

/** @type {!Object} */
self.renderCache_ = {};

https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/ribbon.js:54: * @type {!number}
number (and string, function) are non-nullable by default, so we don't need '!'.
See the Q&A part of
https://docs.google.com/document/d/1Q8ClzNzg5TEi5AM2iwABfWOSGfapuW9POeeyN67Wm...

https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/ribbon.js:313: * @param {!number} index Item index.
ditto

https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/ribbon.js:385: * @param {!string} oldUrl Old url.
ditto

https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/ribbon.js:386: * @param {!string} newUrl New url.
ditto

[yawano, 2014-11-13 08:18:52]

Thank you for the review. PTAL.

https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/ribbon.js (right):

https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/ribbon.js:41: /** @type {!Object} */
self.renderCache_ = {};
On 2014/11/13 07:14:26, fukino wrote:
> I like the following style to be consistent with other classes.
> 
> /** @type {!Object} */
> self.renderCache_ = {};

Done.

https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/ribbon.js:54: * @type {!number}
On 2014/11/13 07:14:26, fukino wrote:
> number (and string, function) are non-nullable by default, so we don't need
'!'.
> See the Q&A part of
>
https://docs.google.com/document/d/1Q8ClzNzg5TEi5AM2iwABfWOSGfapuW9POeeyN67Wm...

Done.

https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/ribbon.js:313: * @param {!number} index Item index.
On 2014/11/13 07:14:26, fukino wrote:
> ditto

Done.

https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/ribbon.js:385: * @param {!string} oldUrl Old url.
On 2014/11/13 07:14:26, fukino wrote:
> ditto

Done.

https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/ribbon.js:386: * @param {!string} newUrl New url.
On 2014/11/13 07:14:26, fukino wrote:
> ditto

Done.

[fukino, 2014-11-13 08:20:22]

On 2014/11/13 08:18:52, yawano wrote:
> Thank you for the review. PTAL.
> 
>
https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
> File ui/file_manager/gallery/js/ribbon.js (right):
> 
>
https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
> ui/file_manager/gallery/js/ribbon.js:41: /** @type {!Object} */
> self.renderCache_ = {};
> On 2014/11/13 07:14:26, fukino wrote:
> > I like the following style to be consistent with other classes.
> > 
> > /** @type {!Object} */
> > self.renderCache_ = {};
> 
> Done.
> 
>
https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
> ui/file_manager/gallery/js/ribbon.js:54: * @type {!number}
> On 2014/11/13 07:14:26, fukino wrote:
> > number (and string, function) are non-nullable by default, so we don't need
> '!'.
> > See the Q&A part of
> >
>
https://docs.google.com/document/d/1Q8ClzNzg5TEi5AM2iwABfWOSGfapuW9POeeyN67Wm...
> 
> Done.
> 
>
https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
> ui/file_manager/gallery/js/ribbon.js:313: * @param {!number} index Item index.
> On 2014/11/13 07:14:26, fukino wrote:
> > ditto
> 
> Done.
> 
>
https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
> ui/file_manager/gallery/js/ribbon.js:385: * @param {!string} oldUrl Old url.
> On 2014/11/13 07:14:26, fukino wrote:
> > ditto
> 
> Done.
> 
>
https://codereview.chromium.org/719273004/diff/20001/ui/file_manager/gallery/...
> ui/file_manager/gallery/js/ribbon.js:386: * @param {!string} newUrl New url.
> On 2014/11/13 07:14:26, fukino wrote:
> > ditto
> 
> Done.

lgtm!

[yawano, 2014-11-14 01:07:09]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2014-11-14 01:08:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/719273004/60001

[commit-bot: I haz the power, 2014-11-14 02:55:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-14 02:55:58]

Patchset 4 (id:??) landed as
https://crrev.com/90c518c26ed4ed5c2c2d84168d0526aa0b2373e3
Cr-Commit-Position: refs/heads/master@{#304158}