adds vp8 and vp9 dxva accelerated decode

Adds code to DXVA to try and load the Intel media decode DLLs, and if successful, to try and instantiate the MFT decoder object for each codec.

BUG=436238
Committed: https://crrev.com/ce0e31e88f841148a9acea2609f43cf8a49b631b
Cr-Commit-Position: refs/heads/master@{#305572}

[luken, 2014-11-24 23:32:12]

luken@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2014-11-25 00:32:55]

Neat! Which platforms does the Intel Media SDK work on?  Do you have a
documentation link for this stuff?

It'd be nice if ananta@ could look over this too as he's more aware of the
intricacies of the DXVA decoder than I.

https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
File content/common/gpu/media/dxva_video_decode_accelerator.cc (right):

https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
content/common/gpu/media/dxva_video_decode_accelerator.cc:648: const wchar_t
kVPXDecoderDLLPath[] = L"Intel\\Media SDK\\";
Typically all these would go in an anonymous namespace at the top of the file.

https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
content/common/gpu/media/dxva_video_decode_accelerator.cc:710: profile ==
media::VP9PROFILE_ANY) {
alignment is wrong.

https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
content/common/gpu/media/dxva_video_decode_accelerator.cc:712:
RETURN_ON_FAILURE(PathService::Get(base::DIR_PROGRAM_FILES, &dll_path),
Does this vary correctly between for "(x86)" and the empty x64 suffix on
Windows?

https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
content/common/gpu/media/dxva_video_decode_accelerator.cc:722: decoder_dll =
::LoadLibrary(dll_path.value().data());
Do you want to specify LOAD_WITH_ALTERED_SEARCH_PATH to prevent loading from
system paths? A la:

https://code.google.com/p/chromium/codesearch#chromium/src/media/base/media_w...

https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
File content/common/gpu/media/dxva_video_decode_accelerator.h (right):

https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
content/common/gpu/media/dxva_video_decode_accelerator.h:79: // Validates
whether the h.264 decoder supports hardware video acceleration.
s/h.264/codec/ everywhere in this file?

[luken, 2014-11-25 01:07:01]

luken@chromium.org changed reviewers:
+ ananta@chromium.org

[luken, 2014-11-25 01:07:02]

The decoding is for Intel Broadwell and Bay Trail CPUs, which will include an
onboard hardware accelerated decoder.

https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
File content/common/gpu/media/dxva_video_decode_accelerator.cc (right):

https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
content/common/gpu/media/dxva_video_decode_accelerator.cc:648: const wchar_t
kVPXDecoderDLLPath[] = L"Intel\\Media SDK\\";
On 2014/11/25 00:32:55, DaleCurtis wrote:
> Typically all these would go in an anonymous namespace at the top of the file.

Done.

https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
content/common/gpu/media/dxva_video_decode_accelerator.cc:710: profile ==
media::VP9PROFILE_ANY) {
On 2014/11/25 00:32:55, DaleCurtis wrote:
> alignment is wrong.

Done.

https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
content/common/gpu/media/dxva_video_decode_accelerator.cc:712:
RETURN_ON_FAILURE(PathService::Get(base::DIR_PROGRAM_FILES, &dll_path),
On 2014/11/25 00:32:55, DaleCurtis wrote:
> Does this vary correctly between for "(x86)" and the empty x64 suffix on
> Windows?

We're still a bit tentative on the path but AFAIK the path is always Program
Files (no x86).

https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
content/common/gpu/media/dxva_video_decode_accelerator.cc:722: decoder_dll =
::LoadLibrary(dll_path.value().data());
On 2014/11/25 00:32:55, DaleCurtis wrote:
> Do you want to specify LOAD_WITH_ALTERED_SEARCH_PATH to prevent loading from
> system paths? A la:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/base/media_w...

Ah, good point, I'll do that.

https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
File content/common/gpu/media/dxva_video_decode_accelerator.h (right):

https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
content/common/gpu/media/dxva_video_decode_accelerator.h:79: // Validates
whether the h.264 decoder supports hardware video acceleration.
On 2014/11/25 00:32:55, DaleCurtis wrote:
> s/h.264/codec/ everywhere in this file?

I cleaned up the comments manually.

[luken, 2014-11-25 01:07:27]

On 2014/11/25 01:07:02, luken wrote:
> The decoding is for Intel Broadwell and Bay Trail CPUs, which will include an
> onboard hardware accelerated decoder.
> 
>
https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
> File content/common/gpu/media/dxva_video_decode_accelerator.cc (right):
> 
>
https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
> content/common/gpu/media/dxva_video_decode_accelerator.cc:648: const wchar_t
> kVPXDecoderDLLPath[] = L"Intel\\Media SDK\\";
> On 2014/11/25 00:32:55, DaleCurtis wrote:
> > Typically all these would go in an anonymous namespace at the top of the
file.
> 
> Done.
> 
>
https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
> content/common/gpu/media/dxva_video_decode_accelerator.cc:710: profile ==
> media::VP9PROFILE_ANY) {
> On 2014/11/25 00:32:55, DaleCurtis wrote:
> > alignment is wrong.
> 
> Done.
> 
>
https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
> content/common/gpu/media/dxva_video_decode_accelerator.cc:712:
> RETURN_ON_FAILURE(PathService::Get(base::DIR_PROGRAM_FILES, &dll_path),
> On 2014/11/25 00:32:55, DaleCurtis wrote:
> > Does this vary correctly between for "(x86)" and the empty x64 suffix on
> > Windows?
> 
> We're still a bit tentative on the path but AFAIK the path is always Program
> Files (no x86).
> 
>
https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
> content/common/gpu/media/dxva_video_decode_accelerator.cc:722: decoder_dll =
> ::LoadLibrary(dll_path.value().data());
> On 2014/11/25 00:32:55, DaleCurtis wrote:
> > Do you want to specify LOAD_WITH_ALTERED_SEARCH_PATH to prevent loading from
> > system paths? A la:
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/base/media_w...
> 
> Ah, good point, I'll do that.
> 
>
https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
> File content/common/gpu/media/dxva_video_decode_accelerator.h (right):
> 
>
https://codereview.chromium.org/719273003/diff/120001/content/common/gpu/medi...
> content/common/gpu/media/dxva_video_decode_accelerator.h:79: // Validates
> whether the h.264 decoder supports hardware video acceleration.
> On 2014/11/25 00:32:55, DaleCurtis wrote:
> > s/h.264/codec/ everywhere in this file?
> 
> I cleaned up the comments manually.

Oh, and sadly there is no documentation currently available.

[DaleCurtis, 2014-11-25 01:10:05]

lgtm then. Thanks for adding this!

[ananta, 2014-11-25 01:14:42]

lgtm

[luken, 2014-11-25 01:20:39]

The CQ bit was checked by luken@chromium.org

[commit-bot: I haz the power, 2014-11-25 01:21:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/719273003/160001

[commit-bot: I haz the power, 2014-11-25 03:20:24]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2014-11-25 03:21:03]

Patchset 9 (id:??) landed as
https://crrev.com/ce0e31e88f841148a9acea2609f43cf8a49b631b
Cr-Commit-Position: refs/heads/master@{#305572}