Update reference builds to r89207.

Update reference builds to r89207.

Also, this change adds:

1-  A REVISION file in reference_builds/, so it'll be clear what SVN revision the
    builds were taken from.

2-  I moved chrome_mac/notes.txt out to a top-level README file with details
    about all platforms.

3-  chrome/ is renamed chrome_win/ to be consistent with other platforms.

4-  chrome_mac/Google Chrome.app is deleted since we will no longer need it once
    something like http://codereview.chromium.org/7171005/ happens.

R=chase@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89574

[cmp, 2011-06-16 21:08:03]

Were these builds taken from the snapshots folder or the continuous folder?  A
couple issues:

1. pyauto is missing, can you add the files *pyauto* from the test folders to
your CL for each of the platforms?  Nirnimesh, will anything else need to be
added to support loading the reference build via pyauto?

2. Moving chrome -> chrome_win will mean needing to update all references to the
Windows reference build.  Did you expect to need all of those changes?  That's
fine, they'll just need to land at the same time as rolling the Windows ref
build in DEPS.

3. Is the linux build from Linux or Linux x64?

[darin (slow to review), 2011-06-16 21:12:04]

On Thu, Jun 16, 2011 at 2:08 PM, <cmp@chromium.org> wrote:

> Were these builds taken from the snapshots folder or the continuous folder?
>  A
> couple issues:
>
> 1. pyauto is missing, can you add the files *pyauto* from the test folders
> to
> your CL for each of the platforms?  Nirnimesh, will anything else need to
> be
> added to support loading the reference build via pyauto?
>

OK.  It isn't obvious that this is needed.  I guess we need a README file
too.



>
> 2. Moving chrome -> chrome_win will mean needing to update all references
> to the
> Windows reference build.  Did you expect to need all of those changes?
>  That's
> fine, they'll just need to land at the same time as rolling the Windows ref
> build in DEPS.
>

Yes, Joe is making that change.  He is adding a UITest::SetUpReference()
method
that'll avoid the code duplication and make it trivial to fix this path.

We won't roll DEPS to this version of the reference builds until after Joe
has landed
his CL.



>
> 3. Is the linux build from Linux or Linux x64?


Linux

Maybe we should check in both and make the test code use the right one?

-Darin



>
>
>
http://codereview.chromium.**org/7192017/<http://codereview.chromium.org/7192...
>

[cmp, 2011-06-16 21:39:47]

I asked this earlier, still curious so I'll try again: Were these builds taken
from the snapshots folder or the continuous folder?

On 2011/06/16 21:12:04, darin wrote:
> OK.  It isn't obvious that this is needed.  I guess we need
> a README file too.

This is the first time it's being added to the reference build.  From now on, it
should be more obvious.  Having a README that described the process you used
would help.

> Yes, Joe is making that change.  He is adding a 
> UITest::SetUpReference() method that'll avoid the
> code duplication and make it trivial to fix this path.

FYI there is already a UIPerfTest::UseReferenceBuild() method.  Joe, you can
reuse that since some tests (like startup_tests) already make use of it and it
can save you some time.  Does that need to move to UITest?  (Can't think of a
UITest that uses the reference build, maybe Darin has such a test in mind
already?)

> We won't roll DEPS to this version of the reference
> builds until after Joe has landed his CL.

SGTM

> > 3. Is the linux build from Linux or Linux x64?
> 
> Linux
> 
> Maybe we should check in both and make the test code
> use the right one?

Linux is fine, just checking.  I don't think it's necessary to add Linux x64
right now.  Feel free to do that if you think it would help.

[jrt, 2011-06-16 21:46:28]

> > Yes, Joe is making that change.  He is adding a 
> > UITest::SetUpReference() method that'll avoid the
> > code duplication and make it trivial to fix this path.
> 
> FYI there is already a UIPerfTest::UseReferenceBuild() method.  Joe, you can
> reuse that since some tests (like startup_tests) already make use of it and it
> can save you some time.  Does that need to move to UITest?  (Can't think of a
> UITest that uses the reference build, maybe Darin has such a test in mind
> already?)

I use UIPerfTest::UseReferenceBuild(). Initially, I didn't know
UseReferenceBuild() existed.

[Nirnimesh, 2011-06-16 21:50:54]

For pyauto to be able to use reference builds, you'd need to save pyautolib.py
and _pyautolib.so (.pyd on win) present in the chrome-<platform>.test directory
in the snapshots.

[darin (slow to review), 2011-06-16 21:56:08]

On Thu, Jun 16, 2011 at 2:39 PM, <cmp@chromium.org> wrote:

> I asked this earlier, still curious so I'll try again: Were these builds
> taken
>
> from the snapshots folder or the continuous folder?
>

https://remedyweb.corp.google.com/guts/ticket.php?mode=edit&id=HD0000005006672



>
> On 2011/06/16 21:12:04, darin wrote:
>
>> OK.  It isn't obvious that this is needed.  I guess we need
>> a README file too.
>>
>
> This is the first time it's being added to the reference build.  From now
> on, it
> should be more obvious.  Having a README that described the process you
> used
> would help.


OK


>
>
>  Yes, Joe is making that change.  He is adding a
>> UITest::SetUpReference() method that'll avoid the
>> code duplication and make it trivial to fix this path.
>>
>
> FYI there is already a UIPerfTest::UseReferenceBuild(**) method.  Joe, you
> can
> reuse that since some tests (like startup_tests) already make use of it and
> it
> can save you some time.  Does that need to move to UITest?  (Can't think of
> a
> UITest that uses the reference build, maybe Darin has such a test in mind
> already?)
>
>
Yeah, that sounds like what we should use / improve.



>
>  We won't roll DEPS to this version of the reference
>> builds until after Joe has landed his CL.
>>
>
> SGTM
>
>
>  > 3. Is the linux build from Linux or Linux x64?
>>
>
>  Linux
>>
>
>  Maybe we should check in both and make the test code
>> use the right one?
>>
>
> Linux is fine, just checking.  I don't think it's necessary to add Linux
> x64
> right now.  Feel free to do that if you think it would help.


I don't know if I should care yet.

-Darin


>
>
>
http://codereview.chromium.**org/7192017/<http://codereview.chromium.org/7192...
>

[darin (slow to review), 2011-06-16 21:56:19]

OK

On Thu, Jun 16, 2011 at 2:50 PM, <nirnimesh@chromium.org> wrote:

> For pyauto to be able to use reference builds, you'd need to save
> pyautolib.py
> and _pyautolib.so (.pyd on win) present in the chrome-<platform>.test
> directory
> in the snapshots.
>
>
>
http://codereview.chromium.**org/7192017/<http://codereview.chromium.org/7192...
>

[darin (slow to review), 2011-06-17 19:21:42]

PTAL thanks!!

[cmp, 2011-06-17 21:50:48]

Wondering if the README and pyauto files got added to your local checkout before
re-uploading since I don't see them..

[darin (slow to review), 2011-06-17 23:51:39]

Yeah, they didn't make it because I forgot to add them :-P

Anyways, thanks for stopping by to review these over the shoulder.  The
change is now committed:  r89574.

-Darin


On Fri, Jun 17, 2011 at 2:50 PM, <cmp@chromium.org> wrote:

> Wondering if the README and pyauto files got added to your local checkout
> before
> re-uploading since I don't see them..
>
>
>
http://codereview.chromium.**org/7192017/<http://codereview.chromium.org/7192...
>