Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4706)

Unified Diff: chrome/browser/history/download_history_info.h

Issue 7192016: chrome.experimental.downloads (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: merged db_handle, id; onCreated, onErased Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/download_database.cc ('k') | chrome/browser/history/download_history_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/download_history_info.h
diff --git a/chrome/browser/history/download_history_info.h b/chrome/browser/history/download_history_info.h
index e7c35d4e934dc29d1dd6933d91f57df8b4c2ec22..515a8a1acfdbb6e1ab5fcb807c516b1a74fba6e1 100644
--- a/chrome/browser/history/download_history_info.h
+++ b/chrome/browser/history/download_history_info.h
@@ -8,8 +8,6 @@
#define CHROME_BROWSER_HISTORY_DOWNLOAD_HISTORY_INFO_H_
#pragma once
-#include <vector>
-
#include "base/file_path.h"
#include "base/time.h"
#include "googleurl/src/gurl.h"
@@ -19,8 +17,6 @@ class DownloadItem;
// Contains the information that is stored in the download history database
// (or refers to it). Managed by the DownloadItem.
struct DownloadHistoryInfo {
- // TODO(ahendrickson) -- Reduce the number of constructors.
- DownloadHistoryInfo();
DownloadHistoryInfo(const FilePath& path,
const GURL& url,
const GURL& referrer,
@@ -28,8 +24,8 @@ struct DownloadHistoryInfo {
int64 received,
int64 total,
int32 download_state,
- int64 handle);
- ~DownloadHistoryInfo(); // For linux-clang.
+ int32 id);
+ ~DownloadHistoryInfo() {}
// The final path where the download is saved.
FilePath path;
@@ -53,8 +49,8 @@ struct DownloadHistoryInfo {
// The current state of the download.
int32 state;
- // The handle of the download in the database.
- int64 db_handle;
+ // This download item's unique persistent identifier.
+ int32 id;
};
#endif // CHROME_BROWSER_HISTORY_DOWNLOAD_HISTORY_INFO_H_
« no previous file with comments | « chrome/browser/history/download_database.cc ('k') | chrome/browser/history/download_history_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698