Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: sky/engine/core/html/parser/MarkupTokenizerInlines.h

Issue 719063002: Revert "Remove support for MSVC" (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/html/parser/MarkupTokenizerInlines.h
diff --git a/sky/engine/core/html/parser/MarkupTokenizerInlines.h b/sky/engine/core/html/parser/MarkupTokenizerInlines.h
index 9b34243738b8da572deb21d4c5ede53966bca8ec..13747c611ffe3eddac916c354b25c309c19463ad 100644
--- a/sky/engine/core/html/parser/MarkupTokenizerInlines.h
+++ b/sky/engine/core/html/parser/MarkupTokenizerInlines.h
@@ -60,6 +60,12 @@ inline void advanceStringAndASSERT(SegmentedString& source, const char* expected
source.advanceAndASSERT(*expectedCharacters++);
}
+#if COMPILER(MSVC)
+// We need to disable the "unreachable code" warning because we want to assert
+// that some code points aren't reached in the state machine.
+#pragma warning(disable: 4702)
+#endif
+
#define BEGIN_STATE(prefix, stateName) case prefix::stateName: stateName:
#define END_STATE() ASSERT_NOT_REACHED(); break;

Powered by Google App Engine
This is Rietveld 408576698