Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: Source/web/LinkHighlight.h

Issue 719053004: Partially revert r181835 to fix link highlighting (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/web/LinkHighlight.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 21 matching lines...) Expand all
32 #include "platform/graphics/Path.h" 32 #include "platform/graphics/Path.h"
33 #include "public/platform/WebCompositorAnimationDelegate.h" 33 #include "public/platform/WebCompositorAnimationDelegate.h"
34 #include "public/platform/WebContentLayer.h" 34 #include "public/platform/WebContentLayer.h"
35 #include "public/platform/WebContentLayerClient.h" 35 #include "public/platform/WebContentLayerClient.h"
36 #include "public/platform/WebLayer.h" 36 #include "public/platform/WebLayer.h"
37 #include "wtf/OwnPtr.h" 37 #include "wtf/OwnPtr.h"
38 #include "wtf/Vector.h" 38 #include "wtf/Vector.h"
39 39
40 namespace blink { 40 namespace blink {
41 41
42 class DisplayList;
43 class Node; 42 class Node;
44 class RenderLayerModelObject; 43 class RenderLayerModelObject;
45 struct WebRect; 44 struct WebRect;
46 class WebViewImpl; 45 class WebViewImpl;
47 46
48 class LinkHighlight final : public WebContentLayerClient, public WebCompositorAn imationDelegate, blink::LinkHighlightClient { 47 class LinkHighlight final : public WebContentLayerClient, public WebCompositorAn imationDelegate, blink::LinkHighlightClient {
49 public: 48 public:
50 static PassOwnPtr<LinkHighlight> create(Node*, WebViewImpl*); 49 static PassOwnPtr<LinkHighlight> create(Node*, WebViewImpl*);
51 virtual ~LinkHighlight(); 50 virtual ~LinkHighlight();
52 51
(...skipping 24 matching lines...) Expand all
77 76
78 void attachLinkHighlightToCompositingLayer(const RenderLayerModelObject* pai ntInvalidationContainer); 77 void attachLinkHighlightToCompositingLayer(const RenderLayerModelObject* pai ntInvalidationContainer);
79 void clearGraphicsLayerLinkHighlightPointer(); 78 void clearGraphicsLayerLinkHighlightPointer();
80 // This function computes the highlight path, and returns true if it has cha nged 79 // This function computes the highlight path, and returns true if it has cha nged
81 // size since the last call to this function. 80 // size since the last call to this function.
82 bool computeHighlightLayerPathAndPosition(const RenderLayerModelObject*); 81 bool computeHighlightLayerPathAndPosition(const RenderLayerModelObject*);
83 82
84 OwnPtr<WebContentLayer> m_contentLayer; 83 OwnPtr<WebContentLayer> m_contentLayer;
85 OwnPtr<WebLayer> m_clipLayer; 84 OwnPtr<WebLayer> m_clipLayer;
86 Path m_path; 85 Path m_path;
87 RefPtr<DisplayList> m_displayList;
88 86
89 RefPtrWillBePersistent<Node> m_node; 87 RefPtrWillBePersistent<Node> m_node;
90 WebViewImpl* m_owningWebViewImpl; 88 WebViewImpl* m_owningWebViewImpl;
91 GraphicsLayer* m_currentGraphicsLayer; 89 GraphicsLayer* m_currentGraphicsLayer;
92 90
93 bool m_geometryNeedsUpdate; 91 bool m_geometryNeedsUpdate;
94 bool m_isAnimating; 92 bool m_isAnimating;
95 double m_startTime; 93 double m_startTime;
96 }; 94 };
97 95
98 } // namespace blink 96 } // namespace blink
99 97
100 #endif 98 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/web/LinkHighlight.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698