Fix the CLD2 GN build on the Mac.

third_party/cld_2/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 
 # May need to make this a build arg, keep the name for now to match gyp
 cld2_table_size = 2
 
 core_files = [
@@ skipping 74 matching lines @@
   configs += [ "//build/config/compiler:no_chromium_code" ]
 
   if (is_win) {
     cflags = [ "/wd4267" ]  # size_t -> int conversion.
   }
 }
 
 # As in the corresponding gyp file, this just builds the core interfaces for
 # CLD2. You must still declare a dependency on a specific data set, either
 # cld2_dynamic or cld2_static. 
-static_library("cld_2") {
+source_set("cld_2") {

[Dirk Pranke, 2014/11/12 02:46:04]

Both this target and the one below have no actual object files. On the mac, this
isn't allowed (libtool explodes).

In GYP, we work around this in the generator by checking to see if there are any
input object files, and if there aren't, we set the target to type 'none'
instead of type 'static library'.

This, however, seems like a misfeature.

Changing this to a source set works, but seems like it might also be the wrong
way to do things. We could change this to a 'group', but groups probably can't
have 'sources' (which in this case only include headers).

Brett, what do you think the right thing to do here is?

   sources = core_files
   include_dirs = [
     "src/internal",
     "src/public",
   ]
 
   configs -= [ "//build/config/compiler:chromium_code" ]
   configs += [ "//build/config/compiler:no_chromium_code" ]
 
   if (is_win) {
     cflags = [ "/wd4267" ]  # size_t -> int conversion.
   }
 }
 
 
-static_library("cld2_platform_impl") {
+source_set("cld2_platform_impl") {
   # TODO: Make this something that can be overridden
   deps = [ ":cld2_static" ]
 }
 
 static_library("cld2_static") {
   sources = core_files + core_impl_files
   include_dirs = [
     "src/internal",
     "src/public",
   ]
@@ skipping 43 matching lines @@
     deps = [ ":cld2_data", ":cld2_dynamic" ]
 
     configs -= [ "//build/config/compiler:chromium_code" ]
     configs += [ "//build/config/compiler:no_chromium_code", ":cld2_dynamic_mode_config" ]
 
     if (is_win) {
       cflags = [ "/wd4267" ]  # size_t -> int conversion.
     }
   }
 }