Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 718913003: Observe surface LCD settings in SkBaseDevice::drawTextBlob() (Closed)

Created:
6 years, 1 month ago by f(malita)
Modified:
6 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org, jbroman
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Observe surface LCD settings in SkBaseDevice::drawTextBlob() We're currently overwriting the paint LCD text flag based on the the run font data => this cancels any LCD filtering we might have performed higher up the stack. BUG=423362 R=reed@google.com Committed: https://skia.googlesource.com/skia/+/112e7e277702e104357f2d44742253ee1b0109ac

Patch Set 1 #

Patch Set 2 : use SkDevice::filterTextFlags() instead #

Patch Set 3 : refactor filterTextFlags #

Patch Set 4 : rebased after device LCD surgery #

Patch Set 5 : re-add filterTextFlags to encapsulate LCD clearing logic #

Total comments: 1

Patch Set 6 : api comment #

Patch Set 7 : adopting Mike's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M include/core/SkDevice.h View 1 2 3 4 5 6 2 chunks +6 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 3 4 1 chunk +3 lines, -5 lines 0 comments Download
M src/core/SkDevice.cpp View 1 2 3 4 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
f(malita)
6 years, 1 month ago (2014-11-12 01:45:35 UTC) #1
f(malita)
Updated to use SkDevice::filterTextFlags() instead (still need to update filterTextFlags to handle surface props and ...
6 years, 1 month ago (2014-11-12 19:18:00 UTC) #2
f(malita)
Updated after today's LCD changes, PTAL. PS#4 is the minimal fix, with some LCD logic ...
6 years, 1 month ago (2014-11-13 21:25:03 UTC) #3
f(malita)
+ API comment
6 years, 1 month ago (2014-11-13 21:47:18 UTC) #4
reed1
lgtm w/ comment request https://codereview.chromium.org/718913003/diff/80001/include/core/SkDevice.h File include/core/SkDevice.h (right): https://codereview.chromium.org/718913003/diff/80001/include/core/SkDevice.h#newcode131 include/core/SkDevice.h:131: uint32_t filterTextFlags(const SkPaint&) const; // ...
6 years, 1 month ago (2014-11-13 21:47:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718913003/120001
6 years, 1 month ago (2014-11-13 21:52:09 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 22:06:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/112e7e277702e104357f2d44742253ee1b0109ac

Powered by Google App Engine
This is Rietveld 408576698