Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 718843002: Remove old crazy comment + fixme (Closed)

Created:
6 years, 1 month ago by leviw_travelin_and_unemployed
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove old crazy comment + fixme Things that make you go 'WAT.' This comment was added in the patch that split RenderBoxModelObject out of RenderBox -- eb6efbfaa79de8624ce72ad4e26ef0d3f808650e -- without any additional explanation. I don't think it's helping anyone. H/T to Ojan for finding today's WAT. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M Source/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
leviw_travelin_and_unemployed
6 years, 1 month ago (2014-11-11 22:10:07 UTC) #2
rune
drive-by lgtm
6 years, 1 month ago (2014-11-11 22:12:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718843002/1
6 years, 1 month ago (2014-11-11 22:23:50 UTC) #6
eae
While poorly worded that comment makes perfect sense to me. As long as we support ...
6 years, 1 month ago (2014-11-11 22:24:06 UTC) #7
eae
...on the other hand, if it has been broken this long without anyone noticing we ...
6 years, 1 month ago (2014-11-11 22:28:36 UTC) #8
mstensho (USE GERRIT)
Sorry to kill the WATness somewhat, but this at least used to be a valid ...
6 years, 1 month ago (2014-11-11 22:33:18 UTC) #10
leviw_travelin_and_unemployed
On 2014/11/11 at 22:33:18, mstensho wrote: > Sorry to kill the WATness somewhat, but this ...
6 years, 1 month ago (2014-11-11 22:35:56 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 23:27:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185151

Powered by Google App Engine
This is Rietveld 408576698