Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 718833002: Classes: Cleanup default constructor flag (Closed)

Created:
6 years, 1 month ago by arv (Not doing code reviews)
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Classes: Cleanup default constructor flag Now that we keep track of whether a function contains super we do not need kDefaultConstructorCallSuper BUG=None LOG=Y R=dslomov@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/04719195a21d693932683867fc92e0a06b897f3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -40 lines) Patch
M src/ast.h View 3 chunks +3 lines, -6 lines 0 comments Download
M src/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/globals.h View 3 chunks +2 lines, -8 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/objects.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/objects-inl.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/parser.cc View 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
arv (Not doing code reviews)
PTAL
6 years, 1 month ago (2014-11-11 22:07:33 UTC) #1
Dmitry Lomov (no reviews)
lgtm
6 years, 1 month ago (2014-11-12 06:57:06 UTC) #2
arv (Not doing code reviews)
6 years, 1 month ago (2014-11-13 16:50:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
04719195a21d693932683867fc92e0a06b897f3d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698