Issue 718793003: Revert of Move from libstlport to libc++ for Android framework builds

Issue 718793003: Revert of Move from libstlport to libc++ for Android framework builds (Closed)

Created:
6 years, 1 month ago by scroggo

Modified:
6 years, 1 month ago

Reviewers:
djsollen, tomhudson

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Move from libstlport to libc++ for Android framework builds (patchset #1 id:1 of https://codereview.chromium.org/714113002/) Reason for revert: The code this depends on is not ready yet. We can submit once https://android-review.googlesource.com/#/c/113924/ is submitted. Original issue's description: > Move from libstlport to libc++ for Android framework builds > > Committed: https://skia.googlesource.com/skia/+/ce259510a738fab05a0d456440104f5aba1c9d72 TBR=tomhudson@google.com,djsollen@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/3c3fe7ce4893204eb8bcf885e8a1d539763bca5d

Patch Set 1 #

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -2 lines)			Patch
M	platform_tools/android/bin/android_gdbserver	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	platform_tools/android/bin/android_perf	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	platform_tools/android/gyp_gen/makefile_writer.py	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	platform_tools/android/gyp_gen/tool_makefile_writer.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	platform_tools/android/tests/expectations/Android.mk	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	platform_tools/android/tests/expectations/tool/Android.mk	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scroggo

Created Revert of Move from libstlport to libc++ for Android framework builds

6 years, 1 month ago (2014-11-11 21:57:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718793003/1

6 years, 1 month ago (2014-11-11 21:58:27 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/3c3fe7ce4893204eb8bcf885e8a1d539763bca5d

6 years, 1 month ago (2014-11-11 21:58:48 UTC) #3

scroggo

6 years, 1 month ago (2014-11-12 19:43:40 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/717303002/ by scroggo@google.com.

The reason for reverting is: The code this depends on has been landed..

Expand Messages | Collapse Messages