Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 71873004: Add mojo and gin to chromium_builder_tests (Closed)

Created:
7 years, 1 month ago by jschuh
Modified:
7 years, 1 month ago
Reviewers:
iannucci
CC:
chromium-reviews
Visibility:
Public.

Description

Add mojo and gin to chromium_builder_tests Prevents x64 regressions from lack of trybot coverage. R=iannucci@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235920

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/all.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jschuh
PTAL
7 years, 1 month ago (2013-11-13 22:20:34 UTC) #1
iannucci
On 2013/11/13 22:20:34, Justin Schuh wrote: > PTAL lgtm to CQ.... there's a lot of ...
7 years, 1 month ago (2013-11-14 01:33:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/71873004/1
7 years, 1 month ago (2013-11-14 03:27:04 UTC) #3
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, compile, content_unittests, crypto_unittests, net_unittests, sql_unittests, ...
7 years, 1 month ago (2013-11-14 03:57:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/71873004/1
7 years, 1 month ago (2013-11-14 14:01:15 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_rel_device for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device&number=95300
7 years, 1 month ago (2013-11-14 14:19:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/71873004/1
7 years, 1 month ago (2013-11-14 18:12:47 UTC) #7
commit-bot: I haz the power
Retried try job too often on ios_rel_device for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device&number=95386
7 years, 1 month ago (2013-11-14 18:35:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/71873004/130003
7 years, 1 month ago (2013-11-14 20:42:04 UTC) #9
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, compile, content_unittests, crypto_unittests, net_unittests, sql_unittests, ...
7 years, 1 month ago (2013-11-14 21:10:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/71873004/1060001
7 years, 1 month ago (2013-11-19 00:22:41 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-19 04:41:59 UTC) #12
Message was sent while issue was closed. 
Change committed as 235920

Powered by Google App Engine
This is Rietveld 408576698