chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc - Issue 718673002: New user type introduced. Combines regular and supervised features.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc

Issue 718673002: New user type introduced. Combines regular and supervised features. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First comments addressed. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc ('K') | « chrome/browser/chromeos/policy/device_status_collector.cc ('k') | chrome/browser/chromeos/policy/user_network_configuration_updater_factory.cc » ('j') | chrome/browser/chromeos/policy/user_network_configuration_updater_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc

diff --git a/chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc b/chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc

index a7ac0a370cd4cece7873be29539f8c6dc5802634..dd3f23d6d9e721c77c0fef73b31a3364b6570984 100644

--- a/chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc

+++ b/chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc

@@ -129,15 +129,15 @@ scoped_ptr<UserCloudPolicyManagerChromeOS>

chromeos::ProfileHelper::Get()->GetUserByProfile(profile);

CHECK(user);

- // Only USER_TYPE_REGULAR users have user cloud policy.

- // USER_TYPE_RETAIL_MODE, USER_TYPE_KIOSK_APP, USER_TYPE_GUEST and

- // USER_TYPE_SUPERVISED are not signed in and can't authenticate the

+ // Only USER_TYPE_REGULAR and USER_TYPE_REGULAR_SUPERVISED users have user

+ // cloud policy. USER_TYPE_RETAIL_MODE, USER_TYPE_KIOSK_APP, USER_TYPE_GUEST

+ // and USER_TYPE_SUPERVISED are not signed in and can't authenticate the

// policy registration.

// USER_TYPE_PUBLIC_ACCOUNT gets its policy from the

// DeviceLocalAccountPolicyService.

// Non-managed domains will be skipped by the below check

const std::string& username = user->email();

- if (user->GetType() != user_manager::USER_TYPE_REGULAR ||

+ if (!user->IsRegular() ||

BrowserPolicyConnector::IsNonEnterpriseUser(username)) {

return scoped_ptr<UserCloudPolicyManagerChromeOS>();

}