chrome/browser/chromeos/policy/device_status_collector.cc - Issue 718673002: New user type introduced. Combines regular and supervised features.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_status_collector.cc

Issue 718673002: New user type introduced. Combines regular and supervised features. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Logical expression fixed. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc ('K') | « chrome/browser/chromeos/login/users/mock_user_manager.h ('k') | chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc » ('j') | chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_status_collector.cc

diff --git a/chrome/browser/chromeos/policy/device_status_collector.cc b/chrome/browser/chromeos/policy/device_status_collector.cc

index 18eb8a0aac4035ac6aa4d88ed530d02d15d699c4..1af72bb4ff1d0f944267bc615fd73172d3fbb414 100644

--- a/chrome/browser/chromeos/policy/device_status_collector.cc

+++ b/chrome/browser/chromeos/policy/device_status_collector.cc

@@ -431,8 +431,8 @@ void DeviceStatusCollector::GetUsers(em::DeviceStatusReportRequest* request) {

user_manager::UserManager::Get()->GetUsers();

user_manager::UserList::const_iterator user;

for (user = users.begin(); user != users.end(); ++user) {

- // Only regular users are reported.

- if ((*user)->GetType() != user_manager::USER_TYPE_REGULAR)

+ // Only users with gaia accounts (regular) are reported.

bartfab (slow) 2014/11/27 12:51:50 Nit: As before, I think we should drop the " (regu

+ if (!(*user)->HasGaiaAccount())

continue;

em::DeviceUser* device_user = request->add_user();