New user type introduced. Combines regular and supervised features.

components/user_manager/user.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_USER_MANAGER_USER_H_
 #define COMPONENTS_USER_MANAGER_USER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 57 matching lines @@
   enum WallpaperType {
     /* DAILY = 0 */    // Removed.
     CUSTOMIZED = 1,    // Selected by user.
     DEFAULT = 2,       // Default.
     /* UNKNOWN = 3 */  // Removed.
     ONLINE = 4,        // WallpaperInfo.location denotes an URL.
     POLICY = 5,        // Controlled by policy, can't be changed by the user.
     WALLPAPER_TYPE_COUNT = 6
   };
 
+  // Returns true if user type has gaia account.

[bartfab (slow), 2014/11/27 12:51:51]

Nit 1: s/user/the user/
Nit 2: s/gaia/a gaia/

+  static bool TypeHasGaiaAccount(UserType user_type);
+
   // Returns the user type.
   virtual UserType GetType() const = 0;
 
   // The email the user used to log in.
   const std::string& email() const { return email_; }
 
   // The displayed user name.
   base::string16 display_name() const { return display_name_; }
 
   // UserInfo
   std::string GetEmail() const override;
   base::string16 GetDisplayName() const override;
   base::string16 GetGivenName() const override;
   const gfx::ImageSkia& GetImage() const override;
   std::string GetUserID() const override;
 
-  // Is user supervised.
+  // Allows managing supervised status of the user. Used for RegularUser.

[bartfab (slow), 2014/11/27 12:51:51]

Nit 1: "Managing" is somewhat overloaded. I think "setting" would be more
neutral.
Nit 2: s/managing supervised status of the user/management of the user's
supervised status/
Nit 3: The reference to the |RegularUser| class here in the header is strange as
that class is only defined as an internal detail in the implementation file. How
about "regular user" instead?

+  virtual void SetIsSupervised(bool is_supervised);
+
+  // Returns true if user has gaia account. True for users of types

[bartfab (slow), 2014/11/27 12:51:51]

Nit 1: s/user/the user/
Nit 2: s/gaia/a gaia/

+  // USER_TYPE_REGULAR and USER_TYPE_REGULAR_SUPERVISED.
+  virtual bool HasGaiaAccount() const;
+
+  // Returns true if user is supervised.
   virtual bool IsSupervised() const;
-  virtual void SetIsSupervised(bool is_supervised);
 
   // Returns the account name part of the email. Use the display form of the
   // email if available and use_display_name == true. Otherwise use canonical.
   std::string GetAccountName(bool use_display_email) const;
 
   // Whether the user has a default image.
   bool HasDefaultImage() const;
 
   // True if user image can be synced.
   virtual bool CanSyncImage() const;
@@ skipping 165 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(User);
 };
 
 // List of known users.
 typedef std::vector<User*> UserList;
 
 }  // namespace user_manager
 
 #endif  // COMPONENTS_USER_MANAGER_USER_H_