Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: ppapi/native_client/tools/browser_tester/browser_tester.py

Issue 71863002: Retry tests more agressively in nacl_integration. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Edit Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/tools/browser_tester/browser_tester.py
diff --git a/ppapi/native_client/tools/browser_tester/browser_tester.py b/ppapi/native_client/tools/browser_tester/browser_tester.py
index e22bfde2994cd2d0d9ab5044ea176905257e3a60..3f1da34b0bde4909bb9a2235f7f3a82d582ea5e0 100755
--- a/ppapi/native_client/tools/browser_tester/browser_tester.py
+++ b/ppapi/native_client/tools/browser_tester/browser_tester.py
@@ -298,6 +298,8 @@ def RunTestsOnce(url, options):
else:
err += '\nThe test probably did not get a callback that it expected.'
listener.ServerError(err)
+ if not server.received_request:
+ raise RetryTest('Chrome hung before running the test.')
break
elif not options.interactive and HardTimeout(options.hard_timeout):
listener.ServerError('The test took over %.1f seconds. This is '
@@ -356,6 +358,17 @@ def Run(url, options):
while True:
try:
result = RunTestsOnce(url, options)
+ if result:
+ # Currently (2013/11/15) nacl_integration is fairly flaky and there is
+ # not enough time to look into it. Retry if the test fails for any
+ # reason. Note that in general this test runner tries to only retry
+ # when a known flake is encountered. (See the other raise
+ # RetryTest(..)s in this file.) This blanket retry means that those
+ # other cases could be removed without changing the behavior of the test
+ # runner, but it is hoped that this blanket retry will eventually be
+ # unnecessary and subsequently removed. The more precise retries have
+ # been left in place to preserve the knowledge.
+ raise RetryTest('HACK retrying failed test.')
break
except RetryTest:
# Only retry once.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698