Retry tests more agressively in nacl_integration.

Retry tests more agressively in nacl_integration.

BUG=317890
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235787

[Mark Seaborn, 2013-11-14 01:27:57]

https://codereview.chromium.org/71863002/diff/1/ppapi/native_client/tools/bro...
File ppapi/native_client/tools/browser_tester/browser_tester.py (right):

https://codereview.chromium.org/71863002/diff/1/ppapi/native_client/tools/bro...
ppapi/native_client/tools/browser_tester/browser_tester.py:361: if result and
options.tool is None:
To be honest, I don't understand why you're adding two new 'raise RetryTest'
cases.  Doesn't this one retry on all failures, so that the first wouldn't be
necessary?

Also, I don't understand why you check options.tool here but not above.

[Nick Bray (chromium), 2013-11-14 18:04:56]

On 2013/11/14 01:27:57, Mark Seaborn wrote:
>
https://codereview.chromium.org/71863002/diff/1/ppapi/native_client/tools/bro...
> File ppapi/native_client/tools/browser_tester/browser_tester.py (right):
> 
>
https://codereview.chromium.org/71863002/diff/1/ppapi/native_client/tools/bro...
> ppapi/native_client/tools/browser_tester/browser_tester.py:361: if result and
> options.tool is None:
> To be honest, I don't understand why you're adding two new 'raise RetryTest'
> cases.  Doesn't this one retry on all failures, so that the first wouldn't be
> necessary?

Yes.  But they do fundamentally different things, and we may want to comment out
the "HACK" at some point.  The retry is more principled and fully tested, so I
left it in when I added the hack.
 
> Also, I don't understand why you check options.tool here but not above.

Because in the first case the test will not have run, yet.  For the HACK, the
test may have partially run and that might mess up whatever tool is being used.

[bradn, 2013-11-15 23:35:22]

lgtm with or without tool

[commit-bot: I haz the power, 2013-11-16 01:07:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncbray@chromium.org/71863002/230001

[commit-bot: I haz the power, 2013-11-16 04:11:52]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-18 17:49:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncbray@chromium.org/71863002/230001

[commit-bot: I haz the power, 2013-11-18 19:07:55]

Change committed as 235787