Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: mojo/services/surfaces/surfaces_impl.h

Issue 718623004: Use Binding<Interface> in surfaces and gles2 code (Closed) Base URL: git@github.com:domokit/mojo.git@connector
Patch Set: use InterfaceRequest<> instead of InterfaceRequest<>* Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/gles2/command_buffer_client_impl.cc ('k') | mojo/services/surfaces/surfaces_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/surfaces/surfaces_impl.h
diff --git a/mojo/services/surfaces/surfaces_impl.h b/mojo/services/surfaces/surfaces_impl.h
index 4cdbe6b1ec526535e1e5137a27f5e07d224a853a..f207a1e6526fe1fbe5a26f2090b99c3ef7f5afef 100644
--- a/mojo/services/surfaces/surfaces_impl.h
+++ b/mojo/services/surfaces/surfaces_impl.h
@@ -9,6 +9,7 @@
#include "cc/surfaces/surface_factory.h"
#include "cc/surfaces/surface_factory_client.h"
#include "mojo/public/cpp/application/application_connection.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
#include "mojo/services/public/interfaces/gpu/command_buffer.mojom.h"
#include "mojo/services/public/interfaces/surfaces/surfaces.mojom.h"
@@ -21,7 +22,7 @@ class ApplicationManager;
class SurfaceNativeViewportClient;
-class SurfacesImpl : public InterfaceImpl<Surface>,
+class SurfacesImpl : public Surface,
public cc::SurfaceFactoryClient,
public cc::DisplayClient {
public:
@@ -34,7 +35,9 @@ class SurfacesImpl : public InterfaceImpl<Surface>,
SurfacesImpl(cc::SurfaceManager* manager,
uint32_t id_namespace,
- Client* client);
+ Client* client,
+ SurfacePtr* surface);
+
~SurfacesImpl() override;
// Surface implementation.
@@ -66,6 +69,7 @@ class SurfacesImpl : public InterfaceImpl<Surface>,
Client* client_;
scoped_ptr<cc::Display> display_;
ScopedMessagePipeHandle command_buffer_handle_;
+ StrongBinding<Surface> binding_;
DISALLOW_COPY_AND_ASSIGN(SurfacesImpl);
};
« no previous file with comments | « mojo/gles2/command_buffer_client_impl.cc ('k') | mojo/services/surfaces/surfaces_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698