Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 718623004: Use Binding<Interface> in surfaces and gles2 code (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@connector
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : use InterfaceRequest<> instead of InterfaceRequest<>* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -22 lines) Patch
M mojo/gles2/command_buffer_client_impl.cc View 1 2 3 chunks +10 lines, -7 lines 0 comments Download
M mojo/services/surfaces/surfaces_impl.h View 1 2 4 chunks +6 lines, -2 lines 0 comments Download
M mojo/services/surfaces/surfaces_impl.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/services/surfaces/surfaces_service_application.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M mojo/services/surfaces/surfaces_service_impl.h View 1 2 3 3 chunks +7 lines, -3 lines 0 comments Download
M mojo/services/surfaces/surfaces_service_impl.cc View 1 2 3 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jamesr
6 years, 1 month ago (2014-11-19 00:06:24 UTC) #2
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-19 00:07:36 UTC) #3
jamesr
6 years, 1 month ago (2014-11-19 00:24:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
52ea6b65d503459ca35b32ab27d275971d8d96f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698