Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 718583002: Accelerator Key's are not visible for Print and Inspect Element in pdf context menu. (Closed)

Created:
6 years, 1 month ago by Deepak
Modified:
6 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Accelerator Key's are not visible for Print and Inspect Element in pdf context menu. Accelerator key's should be visible in context menu,so that user will learn and can use these Accelerator keys for Print and Inspect Element without opening context menu everytime. Changes done to show Accelerator label for Print and Inspect Element. BUG=432004 Committed: https://crrev.com/36ae1ba62b3b4b8dd3b622a76fdd927a08545705 Cr-Commit-Position: refs/heads/master@{#303609}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Deepak
This is follow up for 431313 issue for adding Accelerator key's for "Print" and "Inspect ...
6 years, 1 month ago (2014-11-11 04:52:51 UTC) #2
msw
lgtm with a nit https://codereview.chromium.org/718583002/diff/1/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc File chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc (right): https://codereview.chromium.org/718583002/diff/1/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc#newcode82 chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc:82: ui::Accelerator(ui::VKEY_I, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN); nit: ...
6 years, 1 month ago (2014-11-11 07:27:09 UTC) #3
Deepak
https://codereview.chromium.org/718583002/diff/1/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc File chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc (right): https://codereview.chromium.org/718583002/diff/1/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc#newcode82 chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc:82: ui::Accelerator(ui::VKEY_I, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN); On 2014/11/11 07:27:09, msw wrote: ...
6 years, 1 month ago (2014-11-11 07:35:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718583002/20001
6 years, 1 month ago (2014-11-11 07:36:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-11 08:24:10 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 08:24:47 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36ae1ba62b3b4b8dd3b622a76fdd927a08545705
Cr-Commit-Position: refs/heads/master@{#303609}

Powered by Google App Engine
This is Rietveld 408576698