Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 718573002: Revert "Remove aura and make a pure mojo::View version of the aura::Window FocusController." (Closed)

Created:
6 years, 1 month ago by Elliot Glaysher
Modified:
6 years, 1 month ago
Reviewers:
sky, ojan
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Revert "Remove aura and make a pure mojo::View version of the aura::Window FocusController." This reverts commit bb29e4293b6e60ee721b5be17f9fa9f4989a1981. This is a speculative revert due to android waterfall bots failing. BUG=431047 TBR=ojan@chromium.org,sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6fe9be1ca6bfde7e03a1307682d7ffc7c57dc441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+468 lines, -1174 lines) Patch
M examples/window_manager/window_manager.cc View 5 chunks +67 lines, -14 lines 0 comments Download
M examples/wm_flow/wm/frame_controller.h View 3 chunks +8 lines, -1 line 0 comments Download
M examples/wm_flow/wm/frame_controller.cc View 3 chunks +4 lines, -1 line 0 comments Download
M examples/wm_flow/wm/wm.cc View 3 chunks +70 lines, -5 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/services/public/cpp/view_manager/view_tracker.h View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/services/public/cpp/view_manager/view_tracker.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M mojo/services/window_manager/BUILD.gn View 5 chunks +9 lines, -12 lines 0 comments Download
D mojo/services/window_manager/basic_focus_rules.h View 1 chunk +0 lines, -48 lines 0 comments Download
D mojo/services/window_manager/basic_focus_rules.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D mojo/services/window_manager/focus_controller.h View 1 chunk +0 lines, -100 lines 0 comments Download
D mojo/services/window_manager/focus_controller.cc View 1 chunk +0 lines, -303 lines 0 comments Download
D mojo/services/window_manager/focus_controller_observer.h View 1 chunk +0 lines, -36 lines 0 comments Download
D mojo/services/window_manager/focus_rules.h View 1 chunk +0 lines, -62 lines 0 comments Download
M mojo/services/window_manager/native_viewport_event_dispatcher_impl.h View 1 chunk +1 line, -6 lines 0 comments Download
M mojo/services/window_manager/native_viewport_event_dispatcher_impl.cc View 2 chunks +1 line, -8 lines 0 comments Download
D mojo/services/window_manager/view_event_dispatcher.h View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/services/window_manager/view_event_dispatcher.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/services/window_manager/view_target.h View 1 chunk +0 lines, -64 lines 0 comments Download
D mojo/services/window_manager/view_target.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D mojo/services/window_manager/view_targeter.h View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/services/window_manager/view_targeter.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.h View 8 chunks +56 lines, -38 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.cc View 12 chunks +139 lines, -80 lines 0 comments Download
M sky/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M sky/tools/debugger/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M sky/tools/debugger/debugger.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/tools/debugger/debugger.cc View 2 chunks +2 lines, -4 lines 0 comments Download
A sky/tools/debugger/focus_rules.h View 1 chunk +39 lines, -0 lines 0 comments Download
A sky/tools/debugger/focus_rules.cc View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Elliot Glaysher
6 years, 1 month ago (2014-11-11 00:28:53 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6fe9be1ca6bfde7e03a1307682d7ffc7c57dc441.

Powered by Google App Engine
This is Rietveld 408576698