Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 718563002: IDL: Update test expectations (Closed)

Created:
6 years, 1 month ago by bashi
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Update test expectations https://codereview.chromium.org/683013002 changed the impl name of Window from LocalDOMWindow to DOMWindow. This affects the results of run-bindings-tests. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bashi
PTAL?
6 years, 1 month ago (2014-11-11 00:20:10 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-11-11 01:02:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718563002/1
6 years, 1 month ago (2014-11-11 01:03:50 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 01:21:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185087

Powered by Google App Engine
This is Rietveld 408576698