Issue 7185030: Disabling FLAKY_TestUnauthenticatedFrameNavigation as it's timing out, like on other platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7185030: Disabling FLAKY_TestUnauthenticatedFrameNavigation as it's timing out, like on other platforms (Closed)

Created:
9 years, 6 months ago by joth

Modified:
9 years, 6 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews

Visibility:
Public.

Description

Disabling FLAKY_TestUnauthenticatedFrameNavigation as it's timing out, like on other platforms BUG=43437 TEST=FLAKY_TestUnauthenticatedFrameNavigation Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89458

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/ssl/ssl_browser_tests.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

OK with a comment. Could you do a follow-up? http://codereview.chromium.org/7185030/diff/1/chrome/browser/ssl/ssl_browser_tests.cc File chrome/browser/ssl/ssl_browser_tests.cc (right): http://codereview.chromium.org/7185030/diff/1/chrome/browser/ssl/ssl_browser_tests.cc#newcode1031 chrome/browser/ssl/ssl_browser_tests.cc:1031: ...

9 years, 6 months ago (2011-06-17 08:37:52 UTC) #2

joth

9 years, 6 months ago (2011-06-17 08:43:26 UTC) #3

Thanks!

On 17 June 2011 09:37, <phajdan.jr@chromium.org> wrote:

> OK with a comment. Could you do a follow-up?
>
>
> http://codereview.chromium.**org/7185030/diff/1/chrome/**
>
browser/ssl/ssl_browser_tests.**cc<http://codereview.chromium.org/7185030/diff/1/chrome/browser/ssl/ssl_browser_tests.cc>
> File chrome/browser/ssl/ssl_**browser_tests.cc (right):
>
> http://codereview.chromium.**org/7185030/diff/1/chrome/**
>
browser/ssl/ssl_browser_tests.**cc#newcode1031<http://codereview.chromium.org/7185030/diff/1/chrome/browser/ssl/ssl_browser_tests.cc#newcode1031>
> chrome/browser/ssl/ssl_**browser_tests.cc:1031: defined(OS_MAC)
> Isn't it OS_MACOSX? Anyway, let's stop this nonsense and DISABLE it
> everywhere please. I think Windows+Linux+Mac+ChromeOS covers all
> platforms.
>
>
>
D'oh yes. And agreed.
Is the preferred cleanup to remove the #if scafold altogether? Just doing
that now

Expand Messages | Collapse Messages