Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: mojo/services/test_service/test_request_tracker_application.cc

Issue 718473003: Add mojo::Binding<Interface> for more flexible pipe<->impl binding (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/test_service/test_request_tracker_application.cc
diff --git a/mojo/services/test_service/test_request_tracker_application.cc b/mojo/services/test_service/test_request_tracker_application.cc
index b533377547afc8257c8d3c5046f829f40020e0c6..d25c0fd4fd5fd9d7dc8aae7a2f96cd8606dae031 100644
--- a/mojo/services/test_service/test_request_tracker_application.cc
+++ b/mojo/services/test_service/test_request_tracker_application.cc
@@ -15,8 +15,7 @@ namespace mojo {
namespace test {
TestRequestTrackerApplication::TestRequestTrackerApplication()
- : test_tracked_request_factory_(&context_),
- test_request_tracker_factory_(&context_) {
+ : test_tracked_request_factory_(&context_) {
}
TestRequestTrackerApplication::~TestRequestTrackerApplication() {
@@ -27,8 +26,8 @@ bool TestRequestTrackerApplication::ConfigureIncomingConnection(
// Every instance of the service and recorder shares the context.
// Note, this app is single-threaded, so this is thread safe.
connection->AddService(&test_tracked_request_factory_);
- connection->AddService(&test_request_tracker_factory_);
- connection->AddService(this);
+ connection->AddService<TestTimeService>(this);
+ connection->AddService<TestRequestTracker>(this);
return true;
}
@@ -38,6 +37,14 @@ void TestRequestTrackerApplication::Create(
BindToRequest(new TestTimeServiceImpl(connection), &request);
}
+void TestRequestTrackerApplication::Create(
+ ApplicationConnection* connection,
+ InterfaceRequest<TestRequestTracker> request) {
+ TestRequestTrackerImpl* impl =
+ BindToRequest(new TestRequestTrackerImpl(&context_), &request);
DaveMoore 2014/11/11 17:18:45 Removing OnConnectionEstablished() means we can no
jamesr 2014/11/11 17:47:49 The fact that the OnConnectionEstablished() exists
+ impl->OnConnectionEstablished();
+}
+
} // namespace test
} // namespace mojo

Powered by Google App Engine
This is Rietveld 408576698