Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2876)

Unified Diff: mojo/services/view_manager/view_manager_unittest.cc

Issue 718473003: Add mojo::Binding<Interface> for more flexible pipe<->impl binding (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Rename Binding::router() -> Binding::internal_router() Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/view_manager_unittest.cc
diff --git a/mojo/services/view_manager/view_manager_unittest.cc b/mojo/services/view_manager/view_manager_unittest.cc
index 2386922f8a4784c3d7ae28d8bdc35d1dbd557944..25884e3cbd99f2873d0b3df460d5ce6b44533590 100644
--- a/mojo/services/view_manager/view_manager_unittest.cc
+++ b/mojo/services/view_manager/view_manager_unittest.cc
@@ -351,10 +351,9 @@ class TestViewManagerClientConnection
ViewManagerProxy* proxy() { return &proxy_; }
- // InterfaceImpl:
- void OnConnectionEstablished() override {
- proxy()->set_router(internal_state()->router());
- proxy()->set_view_manager(client());
+ void OnConnectionEstablished() {
+ proxy_.set_router(internal_router());
+ proxy_.set_view_manager(client());
}
// ViewManagerClient:
@@ -443,7 +442,9 @@ class EmbedApplicationLoader : public ApplicationLoader,
// InterfaceFactory<ViewManagerClient> implementation:
void Create(ApplicationConnection* connection,
InterfaceRequest<ViewManagerClient> request) override {
- BindToRequest(new TestViewManagerClientConnection(), &request);
+ auto client_connection = new TestViewManagerClientConnection;
+ BindToRequest(client_connection, &request);
+ client_connection->OnConnectionEstablished();
}
private:
@@ -475,9 +476,6 @@ class TestWindowManagerImpl : public InterfaceImpl<WindowManager> {
return view_manager_client_;
}
- // InterfaceImpl:
- virtual void OnConnectionEstablished() override {}
-
// WindowManager:
void Embed(const String& url,
InterfaceRequest<ServiceProvider> service_provider) override {

Powered by Google App Engine
This is Rietveld 408576698