mojo/services/test_service/test_request_tracker_impl.h - Issue 718473003: Add mojo::Binding<Interface> for more flexible pipe<->impl binding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/test_service/test_request_tracker_impl.h

Issue 718473003: Add mojo::Binding<Interface> for more flexible pipe<->impl binding (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Rename Binding::router() -> Binding::internal_router() Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/test_service/test_request_tracker_impl.h

diff --git a/mojo/services/test_service/test_request_tracker_impl.h b/mojo/services/test_service/test_request_tracker_impl.h

index d2104dc7a67b16a9b5e4a8738c21bced13ef2e29..561107fa63bbdd9e6b8038d22a31521fecea903d 100644

--- a/mojo/services/test_service/test_request_tracker_impl.h

+++ b/mojo/services/test_service/test_request_tracker_impl.h

@@ -33,8 +33,7 @@ class TestRequestTrackerImpl : public InterfaceImpl<TestRequestTracker> {

// TestRequestTracker.

void RecordStats(uint64_t client_id, ServiceStatsPtr stats) override;

- // InterfaceImpl override.

- void OnConnectionEstablished() override;

+ void OnConnectionEstablished();

private:

void UploaderNameCallback(uint64_t id, const mojo::String& name);