Initialize V8 in PDFium from external files (plugin process only)

chrome/plugin/chrome_content_plugin_client.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/plugin/chrome_content_plugin_client.h"
 
 #if defined(ENABLE_REMOTING)
 #include "base/files/file_path.h"
 #include "base/path_service.h"
 #include "content/public/common/content_paths.h"
 #include "media/base/media.h"
 #if defined(OS_WIN)
 #include "base/logging.h"
 #include "base/native_library.h"
 #elif defined(OS_POSIX) && !defined(OS_MACOSX) && defined(USE_NSS)
 #include "crypto/nss_util.h"
 #endif
 #endif
 
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+#include "gin/public/isolate_holder.h"
+#endif
+
 namespace chrome {
 
 void ChromeContentPluginClient::PreSandboxInitialization() {
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA

[raymes, 2014/11/11 03:26:39]

Should we just bury this #ifdef in gin as well or are there times when 
gin::IsolateHolder::LoadV8Snapshot(); needs to be called regardless of the
#ifdef?

[baixo1, 2014/11/11 10:56:11]

+jochen@

LoadV8Snapshot is currently only visible if V8_USE_EXTERNAL_STARTUP_DATA is
defined. When called, it'll try do map the files right away and return a bool
indicating success/failure.

I could expose this function even when V8_USE_EXTERNAL_STARTUP_DATA is *not*
defined as well and make it return "success" in such case (not using external
V8). Are you ok with this, Jochen?

[raymes, 2014/11/11 23:02:22]

Feel free to do this in a followup CL if it requires more complicated changes :)

+  gin::IsolateHolder::LoadV8Snapshot();

[raymes, 2014/11/11 03:26:39]

I suggest getting jschuh@ or cpu@ to review this part of the change, just to
make sure they are ok with adding this in before the sandbox initialization.

[baixo1, 2014/11/11 10:56:11]

+jschuh@ : could you take a look at this, please?

[jschuh, 2014/11/13 00:13:26]

When would this get enabled? I.e. is the V8_USE_EXTERNAL_STARTUP_DATA flag
enabled in stable builds of Chrome that we ship, or is this used in some other
context? 

+#endif
+
 #if defined(ENABLE_REMOTING)
 
   // Load crypto libraries for the Chromoting client plugin.
 #if defined(OS_POSIX) && !defined(OS_MACOSX) && defined(USE_NSS)
   // On platforms where we use system NSS libraries, the .so's must be loaded
   // before the sandbox is initialized.
   crypto::ForceNSSNoDBInit();
   crypto::EnsureNSSInit();
 #elif defined(OS_WIN)
   // crypt32.dll is used to decode X509 certificates for Chromoting.
   base::NativeLibraryLoadError error;
   if (base::LoadNativeLibrary(base::FilePath(L"crypt32.dll"), &error) == NULL)
     LOG(ERROR) << "Failed to load crypto32.dll: " << error.ToString();
 #endif // defined(OS_WIN)
 
   // Load media libraries for the Chromoting client plugin.
   base::FilePath media_path;
   PathService::Get(content::DIR_MEDIA_LIBS, &media_path);
   if (!media_path.empty())
     media::InitializeMediaLibrary(media_path);
 
 #endif // defined(ENABLE_REMOTING)
 }
 
 }  // namespace chrome