Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 718403002: Input type number should return Spinbuttonrole from blink. (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni, aboxhall
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Input type number should return Spinbuttonrole from blink. Continuation of this CL https://codereview.chromium.org/718433002/ This CL depends on https://codereview.chromium.org/723083002/ BUG=385014 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185611

Patch Set 1 #

Patch Set 2 : adding layout test in testexpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXRenderObject.cpp View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review. Thanks!
6 years, 1 month ago (2014-11-13 20:32:38 UTC) #2
shreeramk
On 2014/11/13 20:32:38, shreeramk wrote: > Please review. > Thanks! @Dominic: PTAL. Thanks!!
6 years, 1 month ago (2014-11-18 18:33:45 UTC) #3
dmazzoni
lgtm
6 years, 1 month ago (2014-11-19 17:12:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718403002/20001
6 years, 1 month ago (2014-11-19 17:13:46 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 18:13:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185611

Powered by Google App Engine
This is Rietveld 408576698