Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 718393006: DevTools: Log non-well-formed JSON file name when compiling frontend (Closed)

Created:
6 years, 1 month ago by apavlov
Modified:
6 years, 1 month ago
Reviewers:
aandrey, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Log non-well-formed JSON file name when compiling frontend R=pfeldman NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185450

Patch Set 1 #

Patch Set 2 : Factor out JSON loading and parsing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M Source/devtools/scripts/modular_build.py View 1 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
apavlov
6 years, 1 month ago (2014-11-14 17:16:43 UTC) #1
apavlov
PTAL
6 years, 1 month ago (2014-11-17 13:49:43 UTC) #3
pfeldman
lgtm
6 years, 1 month ago (2014-11-17 14:08:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718393006/20001
6 years, 1 month ago (2014-11-17 14:22:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36855)
6 years, 1 month ago (2014-11-17 16:12:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718393006/20001
6 years, 1 month ago (2014-11-17 16:17:46 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 16:18:35 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185450

Powered by Google App Engine
This is Rietveld 408576698